Enhance Wallet Management, Standardize Models, and Improve Security #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new base transaction schema with common transaction fields - Implement new transaction, subscription, and installment models - Update transaction controller to use new model structure - Modify transaction validation schema to match new model
…updates - Refactor wallet models with base schema and enhanced interfaces - Add new wallet creation DTO with comprehensive validation - Update OpenAPI specification with wallet routes and security definitions - Modify authentication middleware to use bearer token extraction - Implement decorator-based route and OpenAPI metadata generation - Enhance wallet controller with class-based structure and method decorators
- Remove undefined security from auth routes - Add bearer authentication security to wallet controller methods - Update decorator factory to support flexible security configuration
…tation - Refactor query helper to use type-safe pagination parameters - Add new PaginationRequestParameters DTO for consistent pagination - Update controllers to use new pagination helper with async support - Modify wallet and other models to improve type definitions and methods - Reorganize import paths for request and response models
AlpTalhaYazar
added
documentation
- Add population for createdBy, walletType, and walletBalances in wallet query - Optimize pagination helper by pre-calculating total items count - Improve query efficiency with `.clone()` for total items calculation
| const { metadata } = queryHelper({ | ||
| queries: { ...req.query, totalItems }, | ||
| const { metadata } = await queryHelper({ | ||
| queryStrings: PaginationRequestParameters.parse(req.query), |
There was a problem hiding this comment.
just pass req.query here and use PaginationRequestParameters.parse( inside of it. By this way we won't import it everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the Financial Management API, focusing on wallet management, security, model standardization, and improved pagination and validation. Below is a breakdown of the key changes:
Wallet Management Enhancements
Security Improvements
Model Standardization
base.model.ts) to standardize common fields across models.User,Wallet,Transaction) to inherit from the base model, ensuring consistency.SubscriptionandInstallmentto support recurring transactions.Pagination and Query Handling
query-helper.tsto handle pagination more explicitly and efficiently.OpenAPI Documentation
openapi.json) to reflect new and modified endpoints.Validation Enhancements
wallet.dto.ts) to enforce stricter validation rules.Codebase Refactoring
helpertohelpers) for better clarity.requestModelandresponseModel) for improved organization.These changes aim to make the API more robust, secure, and maintainable while providing enhanced functionality for wallet management and transaction handling.