Skip to content

Commit 158fe53

Browse files
[infra] Fix array operation in cherry pick workflow (#243)
1 parent c70291b commit 158fe53

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/scripts/prs/detectTargetBranch.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,16 @@ module.exports = async ({ core, context, github }) => {
5151
const reuestedReviewers = pr.requested_reviewers.map((reviewer) => reviewer.login);
5252

5353
// get a list of the reviews done for the PR
54-
const reviews = github.rest.pulls.listReviews({
54+
const { data: reviews } = github.rest.pulls.listReviews({
5555
owner,
5656
repo,
5757
pull_number: pullNumber,
5858
});
5959

6060
// extract the reviewers who approved the PR from the reviews
61-
const approvingReviewers = reviews
62-
.filter((review) => review.state === 'APPROVED')
63-
.map((review) => review.user.login);
61+
const approvingReviewers =
62+
reviews?.filter((review) => review.state === 'APPROVED').map((review) => review.user.login) ||
63+
[];
6464

6565
// merge the 2 arrays into a single array of unique reviewers
6666
const reviewers = [...new Set([...reuestedReviewers, ...approvingReviewers])];

0 commit comments

Comments
 (0)