Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DashboardLayout] Render NavigationItem.action as ListItem's secondaryAction #4747

Open
marcomele opened this issue Mar 10, 2025 · 1 comment
Open

[DashboardLayout] Render NavigationItem.action as ListItem's secondaryAction #4747

marcomele opened this issue Mar 10, 2025 · 1 comment
Labels
component: layout This is the name of the generic UI component, not the React module! customization: dom Component's DOM customizability, e.g. slot good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@marcomele
Copy link

marcomele commented Mar 10, 2025 •
edited by github-actions bot
Loading

Summary

When a NavigationItem is not a parent item (i.e. it's a button in expanded sidebar view), and an action is provided, pointer event on the action component also propagate to the ListItem component. Following MUI practices, the action component would be better rendered as the ListItem's secondaryAction (or wrapped in the SecondaryAction child component).

Examples

No response

Motivation

No response

Search keywords: dashboard layout navigation item action secondary action
@marcomele marcomele added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 10, 2025
@marcomele marcomele changed the title [DashboardLayout] Render NavigationItem.action in as ListItem's secondaryAction [DashboardLayout] Render NavigationItem.action as ListItem's secondaryAction Mar 10, 2025
@apedroferreira
Copy link
Member

apedroferreira commented Mar 11, 2025 •
edited
Loading

Well noticed, thanks for the suggestion!
Feel free to contribute a PR or I can do it eventually.

@apedroferreira apedroferreira added customization: dom Component's DOM customizability, e.g. slot component: layout This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: layout This is the name of the generic UI component, not the React module! customization: dom Component's DOM customizability, e.g. slot good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apedroferreira @marcomele