Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<FastList> was created with unknown prop 'selectedItems' #409

Open
nix-universe opened this issue Jan 17, 2025 · 3 comments
Open

<FastList> was created with unknown prop 'selectedItems' #409

nix-universe opened this issue Jan 17, 2025 · 3 comments
Assignees
Labels
minor reproduction needed There is no reliable reproduction on the bug report, and the developer cannot reproduce

Comments

@nix-universe
Copy link
Collaborator

nix-universe commented Jan 17, 2025

Observed in dev, not yet in release. Sporadic.

Reproduction

  1. Open the app (dev)
  2. Open console logs.
  3. Try selecting different folders (if necessary, accounts) until the error log appears in the console.

Actual Behaviour

<FastList> was created with unknown prop 'selectedItems'
(anonymous) @ FastList.svelte:325
instance @ FastList.svelte:325
FastList @ FastList.svelte:298
create_fragment @ TableMessageList.svelte:8
TableMessageList @ TableMessageList.svelte:39
create_top_slot @ 3Pane.svelte:7
create_fragment @ SplitterHorizontal.svelte:27
SplitterHorizontal @ SplitterHorizontal.svelte:3
create_right_slot @ 3Pane.svelte:16
create_fragment @ Splitter.svelte:27
Splitter @ Splitter.svelte:3
create_fragment @ 3Pane.svelte:5
_3Pane @ 3Pane.svelte:43
create_else_block @ MailApp.svelte:8
create_fragment @ MailApp.svelte:5
MailApp

Expected Behaviour

No error.

@benbucksch
Copy link
Collaborator

That is inconsequential, just a warning.
We're not passing the multi-selection property in some screens, because we don't need it. We should make it optional.

@benbucksch benbucksch self-assigned this Jan 17, 2025
@benbucksch
Copy link
Collaborator

Actually, we are passing it. I don't know why this error happens. Need reproduction.
FWIW, this happens in the Table View mail window layout.

@benbucksch benbucksch added the reproduction needed There is no reliable reproduction on the bug report, and the developer cannot reproduce label Jan 17, 2025
@NeilRashbrook
Copy link
Collaborator

You don't see this in production because the warning is only generated in development.

FastList declares selectedItems as const but MailApp wants to (indirectly) bind selectedMessages from Selected. I assume it just needs to be declared with let instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor reproduction needed There is no reliable reproduction on the bug report, and the developer cannot reproduce
Projects
None yet
Development

No branches or pull requests

3 participants