switch printing to logs.

Author: bayk

api/src/rest.rs

@@ -239,10 +239,10 @@ impl ApiServer {
 				};
 
 				let mut rt = Runtime::new()
-					.map_err(|e| eprintln!("HTTP API server error: {}", e))
+					.map_err(|e| error!("HTTP API server error: {}", e))
 					.unwrap();
 				if let Err(e) = rt.block_on(server) {
-					eprintln!("HTTP API server error: {}", e)
+					error!("HTTP API server error: {}", e)
 				}
 			})
 			.map_err(|e| ErrorKind::Internal(format!("failed to spawn API thread. {}", e)).into())
@@ -290,10 +290,10 @@ impl ApiServer {
 				};
 
 				let mut rt = Runtime::new()
-					.map_err(|e| eprintln!("HTTP API server error: {}", e))
+					.map_err(|e| error!("HTTP API server error: {}", e))
 					.unwrap();
 				if let Err(e) = rt.block_on(server) {
-					eprintln!("HTTP API server error: {}", e)
+					error!("HTTP API server error: {}", e)
 				}
 			})
 			.map_err(|e| ErrorKind::Internal(format!("failed to spawn API thread. {}", e)).into())

core/fuzz/src/main.rs

@@ -43,7 +43,7 @@ fn generate<W: ser::Writeable>(
 	let dir_path = Path::new("corpus").join(target);
 	if !dir_path.is_dir() {
 		fs::create_dir_all(&dir_path).map_err(|e| {
-			println!("fail: {}", e);
+			error!("fail: {}", e);
 			ser::Error::IOErr("can't create corpus directory".to_owned(), e.kind())
 		})?;
 	}

p2p/src/libp2p_connection.rs

@@ -400,7 +400,7 @@ pub async fn run_libp2p_node(
 	let this_peer_id = PeerId::from_public_key(id_keys.public());
 	set_this_peer_id(&this_peer_id);
 
-	println!("Starting libp2p, this peer: {}", this_peer_id);
+	warn!("Starting libp2p, this peer: {}", this_peer_id);
 	debug_assert_eq!(this_peer_id.to_string(), onion_address.to_string());
 
 	// Building transport
@@ -463,7 +463,7 @@ pub async fn run_libp2p_node(
 	/*   // It is ping pong handler
 	 future::poll_fn(move |cx: &mut Context<'_>| loop {
 		match swarm.poll_next_unpin(cx) {
-			Poll::Ready(Some(event)) => println!("{:?}", event),
+			Poll::Ready(Some(event)) => info!("{:?}", event),
 			Poll::Ready(None) => return Poll::Ready(()),
 			Poll::Pending => return Poll::Pending,
 		}

pool/fuzz/fuzz_targets/common.rs

@@ -113,7 +113,7 @@ impl BlockChain for ChainAdapter {
 // Same as from pool/tests/common.rs
 pub fn clean_output_dir(db_root: String) {
 	if let Err(e) = fs::remove_dir_all(db_root) {
-		println!("cleaning output dir failed - {:?}", e)
+		error!("cleaning output dir failed - {:?}", e)
 	}
 }
 

servers/src/grin/server.rs

@@ -290,7 +290,6 @@ impl Server {
 		let (onion_address, tor_secret) = if config.tor_config.tor_enabled {
 			if !config.p2p_config.host.is_loopback() {
 				error!("If Tor is enabled, host must be '127.0.0.1'.");
-				println!("If Tor is enabled, host must be '127.0.0.1'.");
 				return Err(Error::Configuration(
 					"If Tor is enabled, host must be '127.0.0.1'.".to_owned(),
 				));
@@ -344,13 +343,12 @@ impl Server {
 					})?;
 
 				let resp = output.recv();
-				println!("Finished with TOR");
+				info!("Finished with TOR");
 				let onion_address = resp.unwrap_or(None);
 				if onion_address.is_some() {
 					info!("Tor successfully started: resp = {:?}", onion_address);
 				} else {
 					error!("Tor failed to start!");
-					println!("Failed to start tor. See log for details");
 					std::process::exit(-1);
 				}
 				let secret = output.recv().map_err(|e| {
@@ -363,13 +361,11 @@ impl Server {
 
 				if onion_address.is_none() {
 					error!("onion_address must be specified with external tor. Halting!");
-					println!("onion_address must be specified with external tor. Halting!");
 					std::process::exit(-1);
 				}
 				let otemp = onion_address.clone().unwrap();
 				if otemp == "" {
 					error!("onion_address must be specified with external tor. Halting!");
-					println!("onion_address must be specified with external tor. Halting!");
 					std::process::exit(-1);
 				}
 				info!(

src/bin/grin.rs

@@ -175,7 +175,7 @@ fn real_main() -> i32 {
 		// clean command
 		("clean", _) => {
 			let db_root_path = node_config.unwrap().members.unwrap().server.db_root;
-			println!("Cleaning chain data directory: {}", db_root_path);
+			warn!("Cleaning chain data directory: {}", db_root_path);
 			match std::fs::remove_dir_all(db_root_path) {
 				Ok(_) => 0,
 				Err(_) => 1,

util/src/logger.rs

@@ -343,15 +343,6 @@ fn send_panic_to_log() {
 			}
 			None => error!("thread '{}' panicked at '{}'{:?}", thread, msg, backtrace),
 		}
-		//also print to stderr
-		let tui_running = *TUI_RUNNING.lock();
-		if !tui_running {
-			let config = LOGGING_CONFIG.lock();
-
-			eprintln!(
-				"Thread '{}' panicked with message:\n\"{}\"\nSee {} for further details.",
-				thread, msg, config.log_file_path
-			);
-		}
+		// Node should never print to stdout/std error because it can run without terminal access
 	}));
 }