Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bexley ww ggw misc todos #5381

Draft
wants to merge 20 commits into
base: bexley-ww-ggw-text-fixes
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

Please check the following:

  • Has the code POD documentation been added or updated?
  • Whether this PR should include changes to any public documentation, or the FAQ;
  • All cobrand-specific commits start their commit message with the cobrand in square brackets;
  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Will cobrand-specific changes require additional work to ensure consistent behaviour on www.fixmystreet.com?
  • Are the changes tested for accessibility?
  • Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

Please check the contributing docs, and describe your pull request here.
Screenshots or GIF animations (using e.g. LICEcap) may be helpful.

Please include any issues that are fixed, using "fixes" or "closes" so that
they are auto-closed when the PR is merged.

Thanks for contributing!

@nephila-nacrea nephila-nacrea self-assigned this Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.32%. Comparing base (37eb56f) to head (eb40957).
Report is 16 commits behind head on bexley-ww-ggw-text-fixes.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Garden.pm 93.54% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           bexley-ww-ggw-text-fixes    #5381      +/-   ##
============================================================
+ Coverage                     82.27%   82.32%   +0.04%     
============================================================
  Files                           424      424              
  Lines                         33779    33283     -496     
  Branches                       5376     5344      -32     
============================================================
- Hits                          27793    27399     -394     
+ Misses                         4402     4307      -95     
+ Partials                       1584     1577       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-ggw-misc-todos branch from 7174795 to af28a82 Compare February 25, 2025 22:01
@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-ggw-misc-todos branch from 25ecabb to 32953cc Compare February 26, 2025 11:41
@nephila-nacrea nephila-nacrea changed the base branch from master to bexley-ww-ggw-text-fixes February 26, 2025 11:41
@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-ggw-misc-todos branch from 32953cc to eb40957 Compare February 26, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants