From 6b87344f54c3fefb6c8bab33451b22c22ad572bc Mon Sep 17 00:00:00 2001
From: Alex Parsons <alex.parsons@mysociety.org>
Date: Fri, 23 Feb 2024 16:37:30 +0000
Subject: [PATCH] Abstract person navigation

- Enable votes link for all except NIA and LA
---
 locale/cy_GB.UTF-8/LC_MESSAGES/TheyWorkForYou.po      |  4 +---
 www/docs/mp/index.php                                 |  1 +
 .../templates/html/mp/_person_navigation.php          | 11 +++++++++++
 .../easyparliament/templates/html/mp/profile.php      |  8 +-------
 .../easyparliament/templates/html/mp/recent.php       |  8 +-------
 .../easyparliament/templates/html/mp/votes.php        |  8 +-------
 6 files changed, 16 insertions(+), 24 deletions(-)
 create mode 100644 www/includes/easyparliament/templates/html/mp/_person_navigation.php

diff --git a/locale/cy_GB.UTF-8/LC_MESSAGES/TheyWorkForYou.po b/locale/cy_GB.UTF-8/LC_MESSAGES/TheyWorkForYou.po
index 84b04485d5..79d73b0cca 100644
--- a/locale/cy_GB.UTF-8/LC_MESSAGES/TheyWorkForYou.po
+++ b/locale/cy_GB.UTF-8/LC_MESSAGES/TheyWorkForYou.po
@@ -1798,9 +1798,7 @@ msgstr "Derbyn diweddariadau e-bost"
 msgid "That name is not unique. Please select from the following:"
 msgstr " Nid yw'r enw hwnnw'n unigryw.  Dewiswch o'r canlynol:"
 
-#: www/includes/easyparliament/templates/html/mp/profile.php:21
-#: www/includes/easyparliament/templates/html/mp/recent.php:11
-msgid "Voting Record"
+msgid "Voting Summary"
 msgstr "Record bleidleisio"
 
 #: www/includes/easyparliament/templates/html/mp/profile.php:33
diff --git a/www/docs/mp/index.php b/www/docs/mp/index.php
index 0e6c9c2eae..9d26bcebb9 100644
--- a/www/docs/mp/index.php
+++ b/www/docs/mp/index.php
@@ -302,6 +302,7 @@
 }
 
 // Prepare data for the template
+$data["pagetype"] = $pagetype;
 $data['full_name'] = $MEMBER->full_name();
 $data['person_id'] = $MEMBER->person_id();
 $data['member_id'] = $MEMBER->member_id();
diff --git a/www/includes/easyparliament/templates/html/mp/_person_navigation.php b/www/includes/easyparliament/templates/html/mp/_person_navigation.php
new file mode 100644
index 0000000000..4a4da4ca70
--- /dev/null
+++ b/www/includes/easyparliament/templates/html/mp/_person_navigation.php
@@ -0,0 +1,11 @@
+<div class="person-navigation">
+    <ul>
+        <li <?php if ($pagetype == ""): ?>class="active"<?php endif; ?>><a href="<?= $member_url ?>"><?= gettext('Overview') ?></a></li>
+          <?php if ($this_page == "mp"): ?>
+            <li <?php if ($pagetype == "votes"): ?>class="active"<?php endif; ?>><a href="<?= $member_url ?>/votes"><?= gettext('Voting Summary') ?></a></li>
+          <?php endif; ?>
+          <?php if (in_array($this_page, ["mp", "msp", "ms"])): ?>
+          <li <?php if ($pagetype == "recent"): ?>class="active"<?php endif; ?>><a href="<?= $member_url ?>/recent"><?= gettext('Recent Votes') ?></a></li>
+          <?php endif; ?>
+          </ul>
+</div>
\ No newline at end of file
diff --git a/www/includes/easyparliament/templates/html/mp/profile.php b/www/includes/easyparliament/templates/html/mp/profile.php
index 0b7017384f..85b1b67a74 100644
--- a/www/includes/easyparliament/templates/html/mp/profile.php
+++ b/www/includes/easyparliament/templates/html/mp/profile.php
@@ -10,13 +10,7 @@
 <div class="full-page">
     <div class="full-page__row">
         <div class="full-page__unit">
-            <div class="person-navigation">
-                <ul>
-                    <li class="active"><a href="<?= $member_url ?>"><?= gettext('Overview') ?></a></li>
-                    <li><a href="<?= $member_url ?>/votes"><?= gettext('Voting Record') ?></a></li>
-                    <li><a href="<?= $member_url ?>/recent"><?= gettext('Recent Votes') ?></a></li>
-                </ul>
-            </div>
+            <?php include '_person_navigation.php'; ?>
         </div>
         <div class="person-panels">
             <div class="sidebar__unit in-page-nav">
diff --git a/www/includes/easyparliament/templates/html/mp/recent.php b/www/includes/easyparliament/templates/html/mp/recent.php
index 96605c6596..1f2658b1e9 100644
--- a/www/includes/easyparliament/templates/html/mp/recent.php
+++ b/www/includes/easyparliament/templates/html/mp/recent.php
@@ -5,13 +5,7 @@
 <div class="full-page">
     <div class="full-page__row">
         <div class="full-page__unit">
-            <div class="person-navigation">
-                <ul>
-                    <li><a href="<?= $member_url ?>"><?= gettext('Overview') ?></a></li>
-                    <li><a href="<?= $member_url ?>/votes"><?= gettext('Voting Record') ?></a></li>
-                    <li class="active"><a href="<?= $member_url ?>/recent"><?= gettext('Recent Votes') ?></a></li>
-                </ul>
-            </div>
+            <?php include '_person_navigation.php'; ?>
         </div>
         <div class="person-panels">
             <div class="primary-content__unit">
diff --git a/www/includes/easyparliament/templates/html/mp/votes.php b/www/includes/easyparliament/templates/html/mp/votes.php
index 6c3774d3bb..25b4eb3b50 100644
--- a/www/includes/easyparliament/templates/html/mp/votes.php
+++ b/www/includes/easyparliament/templates/html/mp/votes.php
@@ -9,13 +9,7 @@
 <div class="full-page">
     <div class="full-page__row">
         <div class="full-page__unit">
-            <div class="person-navigation">
-                <ul>
-                    <li><a href="<?= $member_url ?>">Overview</a></li>
-                    <li class="active"><a href="<?= $member_url ?>/votes">Voting Record</a></li>
-                    <li><a href="<?= $member_url ?>/recent">Recent Votes</a></li>
-                </ul>
-            </div>
+            <?php include '_person_navigation.php'; ?>
         </div>
         <div class="person-panels">
             <div class="sidebar__unit in-page-nav">