Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility Reports - Weekly Sorting Feature - Sept 12 #236

Open
laurenweinstein opened this issue Sep 10, 2014 · 19 comments
Open

Facility Reports - Weekly Sorting Feature - Sept 12 #236

laurenweinstein opened this issue Sep 10, 2014 · 19 comments

Comments

@laurenweinstein
Copy link

Hi @boyombo and @rebecca-caktus

I noticed that the weekly sorting feature visual has become a button again. Rich and I spent a long time going through this, and ultimately we were pleased with the visual output seen on staging several weeks ago. We really wanted two things 1.) For the date to be large and visible on the reports and 2.) the drop down to mimic other drop downs in the header. Ideally all drop downs function with consistency, using hovers like in the headers.

Is there any way that we can use the css that Rich put together to remove that button and make it look like what he designed or the original specs requested (attached)? Rich and I had come to a reasonable compromise on something that looked and functioned similarly (Gray text with a small gray arrow that looked like the header drop downs).

If the original design specs requested aren't possible, MVP changes that would be completely fine are:

  • removing the outline and background color on the button
  • just one arrow to the right of the date not two. (Two suggests that the functionality is different from the other drop downs, when it's actually the same - it doesn't sort it's just a selection option.)

Thanks!
screen shot 2014-09-10 at 8 56 58 am
screen shot 2014-08-10 at 11 42 18 am

@boyombo
Copy link
Contributor

boyombo commented Sep 10, 2014

I didn't change the CSS. I only increased the width to accommodate longer
date names like September. I can change it back to the old width but I
doubt it will help much.

The design is complete, not when there is nothing more to add, but when
there is nothing left to take away. - Antoine de Exupery
On Sep 10, 2014 6:00 PM, "laurenweinstein" notifications@github.com wrote:

Hi @boyombo https://github.com/boyombo and @rebecca-caktus
https://github.com/rebecca-caktus

I noticed that the weekly sorting feature visual has become a button
again. Rich and I spent a long time going through this, and ultimately we
were pleased with the visual output seen on staging several weeks ago. We
really wanted two things 1.) For the date to be large and visible on the
reports and 2.) the drop down to mimic other drop downs in the header.
Ideally all drop downs function with consistency, using hovers like in the
headers.

Is there any way that we can use the css that Rich put together to remove
that button and make it look like what he designed or the original specs
requested (attached)? Rich and I had come to a reasonable compromise on
something that looked and functioned similarly (Gray text with a small gray
arrow that looked like the header drop downs).

If the original design specs requested aren't possible, MVP changes that
would be completely fine are:

  • removing the outline and background color on the button
  • just one arrow to the right of the date not two. (Two suggests that
    the functionality is different from the other drop downs, when it's
    actually the same - it doesn't sort it's just a selection option.)

Thanks!
[image: screen shot 2014-09-10 at 8 56 58 am]
https://cloud.githubusercontent.com/assets/7979915/4217730/f6b83058-38ea-11e4-80ce-796b0dcff1e2.png
[image: screen shot 2014-08-10 at 11 42 18 am]
https://cloud.githubusercontent.com/assets/7979915/4217742/153ed6d0-38eb-11e4-9bc7-f97d39333eb8.png

Reply to this email directly or view it on GitHub
#236.

@boyombo
Copy link
Contributor

boyombo commented Sep 10, 2014

I'll take another look when I get home

The design is complete, not when there is nothing more to add, but when
there is nothing left to take away. - Antoine de Exupery

I didn't change the CSS. I only increased the width to accommodate longer
date names like September. I can change it back to the old width but I
doubt it will help much.

The design is complete, not when there is nothing more to add, but when
there is nothing left to take away. - Antoine de Exupery
On Sep 10, 2014 6:00 PM, "laurenweinstein" notifications@github.com wrote:

Hi @boyombo https://github.com/boyombo and @rebecca-caktus
https://github.com/rebecca-caktus

I noticed that the weekly sorting feature visual has become a button
again. Rich and I spent a long time going through this, and ultimately we
were pleased with the visual output seen on staging several weeks ago. We
really wanted two things 1.) For the date to be large and visible on the
reports and 2.) the drop down to mimic other drop downs in the header.
Ideally all drop downs function with consistency, using hovers like in the
headers.

Is there any way that we can use the css that Rich put together to remove
that button and make it look like what he designed or the original specs
requested (attached)? Rich and I had come to a reasonable compromise on
something that looked and functioned similarly (Gray text with a small gray
arrow that looked like the header drop downs).

If the original design specs requested aren't possible, MVP changes that
would be completely fine are:

  • removing the outline and background color on the button
  • just one arrow to the right of the date not two. (Two suggests that
    the functionality is different from the other drop downs, when it's
    actually the same - it doesn't sort it's just a selection option.)

Thanks!
[image: screen shot 2014-09-10 at 8 56 58 am]
https://cloud.githubusercontent.com/assets/7979915/4217730/f6b83058-38ea-11e4-80ce-796b0dcff1e2.png
[image: screen shot 2014-08-10 at 11 42 18 am]
https://cloud.githubusercontent.com/assets/7979915/4217742/153ed6d0-38eb-11e4-9bc7-f97d39333eb8.png

Reply to this email directly or view it on GitHub
#236.

@laurenweinstein
Copy link
Author

Okay no problem then. Thanks for adjusting the width.

@laurenweinstein
Copy link
Author

@boyombo It looks like the "Feedback on Services" Section isn't filtering by date. It still shows all of the survey data. I'm including screen shots from Gwagi's current week. Could you look into this for us when you get a chance?
screen shot 2014-09-10 at 7 14 48 pm
screen shot 2014-09-10 at 7 14 43 pm

@laurenweinstein
Copy link
Author

@boyombo
Also the comment headers don't seem to reflect the new questions. Could we update those?:
screen shot 2014-09-11 at 8 59 49 am

@boyombo
Copy link
Contributor

boyombo commented Sep 11, 2014

Ok, i'll look at it.

On Thu, Sep 11, 2014 at 2:00 PM, laurenweinstein notifications@github.com
wrote:

@boyombo https://github.com/boyombo
Also the comment headers don't seem to reflect the new questions. Could we
update those?:
[image: screen shot 2014-09-11 at 8 59 49 am]
https://cloud.githubusercontent.com/assets/7979915/4234115/93f35172-39b3-11e4-85bc-6d9f67bf2f97.png

Reply to this email directly or view it on GitHub
#236 (comment)
.

@boyombo
http://bayo.opadeyi.net
A designer knows he has achieved perfection not when there is nothing left
to add, but when there is nothing left to take away.
--Antoine de Saint-Exupery

@laurenweinstein
Copy link
Author

hi @boyombo

For the "Current Week" option on the sorting feature, can we have this sort by the day of access and 7 days prior? For example, if I accessed the report today and clicked on current week, it would show me Tuesday September 9 - Tuesday September 16.

Let me know what you think about this.

@boyombo
Copy link
Contributor

boyombo commented Sep 17, 2014

Hi @laurenweinstein
It will mean the other previous week might have overlapping dates and be confusing.
Right now we have the weeks follow each other (Actually they are in reverse order - should correct this).
Is there any particular reason we may want this?

@laurenweinstein
Copy link
Author

@boyombo We would like this because right now the lga prints on wednesdays,
if they try to print the current week, they'll only get data for Monday
Tuesday Wednesday. Allowing the current week function to always count back
7 days from the day you select it enables the person printing and the LGA
to decide to print on any day they like (we can't expect all of the LGAs to
want to print on Wednesday). Do you have another suggestion?

I think we would like to reduce the complexity of having people select
start and end dates, but I suppose that's another option.

Lauren

On Wed, Sep 17, 2014 at 5:16 AM, Bayo Opadeyi notifications@github.com
wrote:

Hi @laurenweinstein https://github.com/laurenweinstein
It will mean the other previous week might have overlapping dates and be
confusing.
Right now we have the weeks follow each other (Actually they are in
reverse order - should correct this).
Is there any particular reason we may want this?


Reply to this email directly or view it on GitHub
#236 (comment)
.

Lauren Weinstein
DESIGN ASSOCIATE
152 West 25th St. 6th Floor | New York, NY 10001 USA
office: +1 212 388 1010 | mobile: +1 973 271 2397
nigeria mobile | +234 814 223 5832, +234 817 128 4124
lauren@reboot.org
www.reboot.org

@boyombo
Copy link
Contributor

boyombo commented Sep 17, 2014

Ok, we can do that.
Thanks

On Sep 17, 2014 12:20 PM, "laurenweinstein" notifications@github.com
wrote:

@boyombo We would like this because right now the lga prints on
wednesdays,
if they try to print the current week, they'll only get data for Monday
Tuesday Wednesday. Allowing the current week function to always count back
7 days from the day you select it enables the person printing and the LGA
to decide to print on any day they like (we can't expect all of the LGAs
to
want to print on Wednesday). Do you have another suggestion?

I think we would like to reduce the complexity of having people select
start and end dates, but I suppose that's another option.

Lauren

On Wed, Sep 17, 2014 at 5:16 AM, Bayo Opadeyi notifications@github.com
wrote:

Hi @laurenweinstein https://github.com/laurenweinstein
It will mean the other previous week might have overlapping dates and be
confusing.
Right now we have the weeks follow each other (Actually they are in
reverse order - should correct this).
Is there any particular reason we may want this?

Reply to this email directly or view it on GitHub
<
https://github.com/myvoice-nigeria/myvoice/issues/236#issuecomment-55868544>

.

Lauren Weinstein
DESIGN ASSOCIATE
152 West 25th St. 6th Floor | New York, NY 10001 USA
office: +1 212 388 1010 | mobile: +1 973 271 2397
nigeria mobile | +234 814 223 5832, +234 817 128 4124
lauren@reboot.org
www.reboot.org

Reply to this email directly or view it on GitHub
#236 (comment)
.

@priyankaincode
Copy link

Hey @boyombo - also wanted to check in on this, as I know the request was originally posted 9 days ago and it would be pretty useful for the LGA staff. Can I get a progress update? Thanks!

@boyombo
Copy link
Contributor

boyombo commented Sep 19, 2014

Hi @priyankacpathak , I think there are about a couple of issues in this one.

  • The drop-down no longer looking like a menu (css will need some more tweaking)
  • The feedback on services not filtering by date (on staging)
  • Comment headers not reflecting new questions (not yet implemented)
  • Current week showing the last 7 days instead of the Calendar week (not yet implemented)

I'm working on the last 2 features and should have them up over the weekend.

@priyankaincode
Copy link

Hey @boyombo - thanks for the update! You are correct that the drop down mayyy not have to be a menu anymore. You would know best about this, but I imagine Lauren's request could be implemented in one of two ways: either keeping the drop down menu and updating the date ranges dynamically based on the current date (which would save CSS efforts) or alternatively, presenting a calendar instead of a menu and allowing the user to select the date range, which I believe was discussed before as well. @laurenweinstein is one preferable over the other?

@laurenweinstein
Copy link
Author

@boyombo Could you give us a quick update on progress with the weekly filter? Is there anything @priyankacpathak and I should see on staging? Additionally, the weekly filter doesn't seem to be updating in some cases for weeks in september after the 15th. Is that just because in some cases there are no new surveys? Could you confirm that additional weeks added as needed? Thanks!

@laurenweinstein
Copy link
Author

@boyombo let me know when we can chat for a few minutes on progress here. I think a solution like this could be more useful longterm, but want to see where you are at with the Current Week update currently. Friday you said it would finished before mid week, should I be seeing this on staging? Let me know!

screen shot 2014-09-24 at 11 00 25 am

@boyombo
Copy link
Contributor

boyombo commented Sep 24, 2014

Hi Lauren,

I worked on it last weekend but noticed some issues.
Not finished yet, sorry.
I have been a little distracted lately.

I will get back to you.

On Wed, Sep 24, 2014 at 4:03 PM, laurenweinstein notifications@github.com
wrote:

@boyombo https://github.com/boyombo let me know when we can chat for a
few minutes on progress here. I think a solution like this could be more
useful longterm, but want to see where you are at with the Current Week
update currently. Friday you said it would finished before mid week, should
I be seeing this on staging? Let me know!

[image: screen shot 2014-09-24 at 11 00 25 am]
https://cloud.githubusercontent.com/assets/7979915/4390242/b35eb5b8-43fb-11e4-9006-4e3b54d5f64a.png

Reply to this email directly or view it on GitHub
#236 (comment)
.

@boyombo
http://bayo.opadeyi.net
A designer knows he has achieved perfection not when there is nothing left
to add, but when there is nothing left to take away.
--Antoine de Saint-Exupery

@boyombo
Copy link
Contributor

boyombo commented Sep 26, 2014

Hi @laurenweinstein @priyankacpathak
I have implemented this:
Current week showing the last 7 days instead of the Calendar week (not yet implemented)

and am currently (tomorrow morning) working on:
Comment headers not reflecting new questions (not yet implemented)

@boyombo
Copy link
Contributor

boyombo commented Oct 30, 2014

Hi @laurenweinstein can you review this on staging?

@laurenweinstein
Copy link
Author

Looks good to me! Thanks Bayo!

On Thu, Oct 30, 2014 at 2:47 PM, Bayo Opadeyi notifications@github.com
wrote:

Hi @laurenweinstein https://github.com/laurenweinstein can you review
this on staging?


Reply to this email directly or view it on GitHub
#236 (comment)
.

Lauren Weinstein
DESIGN ASSOCIATE
152 West 25th St. 6th Floor | New York, NY 10001 USA
office: +1 212 388 1010 | mobile: +1 973 271 2397
nigeria mobile | +234 814 223 5832, +234 817 128 4124
lauren@reboot.org
www.reboot.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants