Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract compilation fails due to borsh update #82

Open
amgando opened this issue Jul 2, 2020 · 4 comments
Open

contract compilation fails due to borsh update #82

amgando opened this issue Jul 2, 2020 · 4 comments

Comments

@amgando
Copy link

amgando commented Jul 2, 2020

https://travis-ci.com/github/near/create-near-app/jobs/356517030#L670-L709

Compiling status-message v0.1.0 (/home/travis/build/near/create-near-app/tmp-project/contract)
error[E0277]: the trait bound `Welcome: borsh::de::BorshDeserialize` is not satisfied

while dependabot is trying to bump borsh from 0.6.2 to 0.7.0 in github/near/create-near-app/common/contracts/rust

not sure what to do about this

@bowenwang1996
Copy link
Contributor

We need to reexport dependency from near-sdk-rs to avoid this near/near-sdk-rs#164

@chadoh
Copy link

chadoh commented Jul 21, 2020

@bowenwang1996 does this mean we should wait for a newer version of borsh and skip the 0.7.0 update?

@bowenwang1996
Copy link
Contributor

It's related to near-sdk-rs version, not borsh version. Looks like it should be fixed now with near-sdk-rs version 1.0.0

@chadoh
Copy link

chadoh commented Jul 22, 2020

For reference, here's how I fixed this for create-near-app near/create-near-app#408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants