Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record "last used" date for kernels that were started without the table #29

Closed
krassowski opened this issue May 17, 2024 · 4 comments · Fixed by #39
Closed

Record "last used" date for kernels that were started without the table #29

krassowski opened this issue May 17, 2024 · 4 comments · Fixed by #39

Comments

@krassowski
Copy link
Member

Currently kernels that are started outside of the extension UI do not get "last used" date updated.
This is in particular problematic if user opens a with an already associated kernel as this makes "last used" column value different than what expected by the user.

We can do better by listening to kernels as they get started via services API, regardless of what started them.

@krassowski
Copy link
Member Author

May require a decision on #2

@ericdatakelly
Copy link

More testing in case it helps:
I made a new environment, which I assume creates a new kernel, but still I saw no change to the "last used" value (still shows "Never"). Next I selected "Shut down all kernels", stopped JLab, logged out of Nebari, waited 6 minutes, logged back in and restarted JLab with a different server size (small instead of tiny). "Last used"still showed "Never".

@krassowski
Copy link
Member Author

krassowski commented May 20, 2024

I made a new environment, which I assume creates a new kernel , but still I saw no change to the "last used" value (still shows "Never")

The definition of "used" is that the kernel was created/used (i.e. notebook was opened and kernel was started), not that the environment was used. Detecting when an environment was used would be a much harder problem.

@krassowski
Copy link
Member Author

I can reproduce a bug in that when the kernel is selected in the pop-up dialog it does not get recorded. The launcher itself is not affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants