Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Re-add the blue "+" button in the top left corner to open the launcher. #51

Closed
Adam-D-Lewis opened this issue Jun 11, 2024 · 2 comments · Fixed by #53
Closed

Comments

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jun 11, 2024

Feature description

I miss the blue "+" button in the top left corner to open the launcher. Now I have to click File/New to open the launcher. Is it possible to readd the blue "+" to open the launcher? I don't think there's another way to open the launcher, is there?

image

Value and/or benefit

Familiar UX

Anything else?

No response

@krassowski
Copy link
Member

I also noticed this recently, totally agree. This looks like a bug as the code for activating the button is included in this extension:

https://github.com/nebari-dev/jupyterlab-new-launcher/blob/5aafb2ac13f17764778e72d3d3e60ca04bc5c3b8/src/index.ts#L202-L212

but for some reason it does not make the button appear 🤔

@krassowski
Copy link
Member

Nah, this is the other add button. The one we are missing would need to be added by schema like in https://github.com/jupyterlab/jupyterlab/blob/130089eddb330a44f7f9d496b1e64eddcb497d6b/packages/launcher-extension/schema/plugin.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants