-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a settings button or menu (in top right corner?) #9
Comments
I like this idea. The name may change to something more specific, but I had to actually read through the list of settings to find the settings for "New Launcher" because the name is fairly generic. This would really help jump right to it. |
@krassowski, have you started on this, or is this something I can take a stab at? |
No, I haven't - feel free to pick it up |
@krassowski, I've been trying to figure out how to open the specific settings page via a button, and I am struggling to find a way. It looks like I can use If that's the case, then I think I will need to go with the second option here of adding a dropdown for key settings. Above you mentioned the setting for showing starred section. What other sections do you think should be included here? |
Something like this should work: app.commands.execute('settingeditor:open', {
query: 'New Launcher'
})
I think that would be best in either case - I think having quick settings may make them more discoverable.
Including a toggle for Maybe something like:
We can add more items later. I think you use |
Any updates @andrewfulton9? |
@krassowski, it's coming along. I've added commands for the new options, and added the commands to a Menu object. I am currently working on displaying the menu in a popup opened from a settings icon. |
We could add the cog icon in the top right corner:
It could either open the existing settings section (which currently is 3-4 clicks away):
Or show a small menu allowing to toggle some quick settings (like whether to show starred section).
Thoughts?
The text was updated successfully, but these errors were encountered: