Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a settings button or menu (in top right corner?) #9

Closed
krassowski opened this issue May 7, 2024 · 7 comments · Fixed by #52
Closed

Add a settings button or menu (in top right corner?) #9

krassowski opened this issue May 7, 2024 · 7 comments · Fixed by #52

Comments

@krassowski
Copy link
Member

We could add the cog icon in the top right corner:

image

It could either open the existing settings section (which currently is 3-4 clicks away):

image

Or show a small menu allowing to toggle some quick settings (like whether to show starred section).

Thoughts?

@kcpevey
Copy link

kcpevey commented May 8, 2024

I like this idea. The name may change to something more specific, but I had to actually read through the list of settings to find the settings for "New Launcher" because the name is fairly generic. This would really help jump right to it.

@andrewfulton9
Copy link
Collaborator

@krassowski, have you started on this, or is this something I can take a stab at?

@krassowski
Copy link
Member Author

No, I haven't - feel free to pick it up

@andrewfulton9
Copy link
Collaborator

@krassowski, I've been trying to figure out how to open the specific settings page via a button, and I am struggling to find a way. It looks like I can use settingeditor:open, but I don't think I can pass it any arguments to specify specific plugins. Am I missing something?

If that's the case, then I think I will need to go with the second option here of adding a dropdown for key settings. Above you mentioned the setting for showing starred section. What other sections do you think should be included here?

@krassowski
Copy link
Member Author

It looks like I can use settingeditor:open, but I don't think I can pass it any arguments to specify specific plugins.

Something like this should work:

app.commands.execute('settingeditor:open', {
  query: 'New Launcher'
})

If that's the case, then I think I will need to go with the second option here of adding a dropdown for key settings

I think that would be best in either case - I think having quick settings may make them more discoverable.

What other sections do you think should be included here?

Including a toggle for searchAllSections might be valuable too.

Maybe something like:

✓ Search in All Sections
✓ Show Starred Section
  Open Settings

We can add more items later. I think you use Menu class and add commands to it (which will need to be created).

@krassowski
Copy link
Member Author

Any updates @andrewfulton9?

@andrewfulton9
Copy link
Collaborator

@krassowski, it's coming along. I've added commands for the new options, and added the commands to a Menu object. I am currently working on displaying the menu in a popup opened from a settings icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants