Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 5 feedback #5

Open
tombisho opened this issue Aug 26, 2021 · 0 comments
Open

Chapter 5 feedback #5

tombisho opened this issue Aug 26, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@tombisho
Copy link
Collaborator

Here there are the two options to either generate the survival object separately or in line. It would be good to know the reasons for using each approach. There could be more explanation about strata.

I think also the assign function needs to be included here as another option. The motivation for creating the model on the server side could be borrowed from the ds.glmassign functions? (at a guess it is in case you want to use the model for prediction?).

It would be good to understand how cox_model_full is different to the standard output from survival (I think some things are supressed?). And is it possible to run summary(cox_model_full) on the client side?

I think it would be nice to show the results from these steps, so can we work together to find out why the code won't run against opal-sandbox?

@neelsoumya neelsoumya self-assigned this Aug 27, 2021
@neelsoumya neelsoumya added the enhancement New feature or request label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants