[BUG] - Technical Audit: Spectral #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to wavelet transform where frequencys are now plotted on the y-axis.
…otted with frequencies along y-axis.
…because compute_wavelet_spectrum requires it.
…e to wavelet transform where frequencys are now plotted on the y-axis.
…otted with frequencies along y-axis.
…because compute_wavelet_spectrum requires it.
… issue193_spectral
ryanhammonds
reviewed
Jul 7, 2020
There was a problem hiding this comment.
Looks good. What happened to #200? We should probably squash this when merging.
TomDonoghue
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After comments from the previous PR, this updated PR is pretty short. It basically fixes the incorrect calculation of how power is computed for the wavelet spectrum.