Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove return type #50362

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

miaulalala
Copy link
Contributor

Summary

Since this a backwards- incompatible change, let's remove the types.

cc @blizzz

TODO

  • ...

Checklist

@blizzz blizzz added bug 3. to review Waiting for reviews labels Jan 23, 2025
@blizzz blizzz added this to the Nextcloud 31 milestone Jan 23, 2025
@blizzz
Copy link
Member

blizzz commented Jan 23, 2025

/backport to stable31

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need to remove the return type I think, the parameter type should be fine.

@blizzz
Copy link
Member

blizzz commented Jan 23, 2025

You only need to remove the return type I think, the parameter type should be fine.

aye

@miaulalala miaulalala requested review from susnux and come-nc January 23, 2025 17:13
@blizzz
Copy link
Member

blizzz commented Jan 23, 2025

Github is having bad hair day https://www.githubstatus.com/incidents/gszmt35n7k20

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/noid/revert-api-breaking-return-type branch from f277521 to 1562db8 Compare January 23, 2025 17:34
@miaulalala
Copy link
Contributor Author

/backport to stable31

@blizzz blizzz changed the title fix: remove typing and return type fix: remove return type Jan 23, 2025
@blizzz
Copy link
Member

blizzz commented Jan 23, 2025

Reuse is unrelated here.

@blizzz blizzz merged commit 60e8503 into master Jan 23, 2025
188 of 189 checks passed
@blizzz blizzz deleted the fix/noid/revert-api-breaking-return-type branch January 23, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants