Entity STI not working in OneHasOne relationship

[martenb]

Describe the bug
We are using same personal_data table for admins and users. So, we have 1:1 relationship between them. This feature stops working in v5.

To Reproduce
If you need, i can try to create test with failure.

Versions::

• Orm: 5.0.1
• Dbal: 5.0

[hrach]

I don't necessarily need a test case, but the error would be valuable.

[martenb]

[hrach]

Could you please provide the class/STI hierarchy?

[hrach]

@martenb 🙏

[martenb]

Ok, here is "minimal" code sample. Works properly with v4...

/**
 * @property-read int $id {primary}
 * @property AdminPersonalData $personalData {1:1 AdminPersonalData::$admin, cascade=[persist, remove]}
 */
class Admin extends Entity

/**
 * @property Admin $admin {1:1 Admin::$personalData, isMain=true}
 */
class AdminPersonalData extends PersonalData

/**
 * @property-read int $id {primary}
 */
abstract class PersonalData extends Entity

class PersonalDataRepository extends Repository
{

	public static function getEntityClassNames(): array
	{
		return [PersonalData::class, AdminPersonalData::class, UserPersonalData::class];
	}

	public function getEntityClassName(array $data): string
	{
		return isset($data['admin'])
			? AdminPersonalData::class
			: UserPersonalData::class;
	}

}

[hrach]

Thanks a lot.

[hrach]

@martenb Hi, I tried to reproduce this but sadly I'm unable to do so. My test cases include a query from both sides of the the relationship.

So to debug, please:

• do you see a correct SQL?
• does running the SQL yourself return the wanted data?
• at HasOne:181 - could you dump($this->value); to see if there is something?

[hrach]

@martenb could you please help me with reproduction? thx.

[martenb]

Sure, I was on vacation..

[hrach]

Thx a lot for the report, fixed; you may test it by updating to v5.0 branch.

[martenb]

Looks ok, thx

[hrach]

Thx, released as https://github.com/nextras/orm/releases/tag/v5.0.1.