-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zero config detection issue with turborepo #3051
Comments
You are right, works in a minimal reproduction repo that I created. I figured this is an issue of Turborepo that I am using: Turborepo is actually removing all environment variables that are not on the allowlist ( Could you tell me what environemnt variable is used to determine that the preset cloudflare-pages should be used? I dont find the select logic in the repo. I can then open an issue at Turborepo to not remove this variable. Workaround: |
CF_PAGES you can find the logic here: https://github.com/unjs/std-env/blob/main/src/providers.ts#L72 If had time do you mind to open a PR to mention about turbo repo workaround in cloudflare pages section? 🙏 |
Probably ALL providers would need an info that they dont get auto detected when using Turborepo without explicitly allowing the variables or setting I opened an issue: vercel/turborepo#9860 I know they already have |
We can add banner here instead in meanwhile: https://nitro.build/deploy#zero-config-providers |
Environment
Describe the bug
When deploying to Cloudflare Pages, the preset 'node-server' is selected instead of 'cloudflare-pages'. This leads to all deployments failing. I tried with both v2 and nightly v3.
Maybe some changes have been made at Cloudflare so the detection mechanism doesnt work anymore? My last successful deployment was on 14th of December. My next deployment on 16th of December failed because of selecting preset 'node-server'.
Additional informations
My Nuxt projects are still using the 'cloudflare-pages' preset.
Workaround
Set preset manually in package.json:
"build": "NITRO_PRESET='cloudflare-pages' nitro build",
The text was updated successfully, but these errors were encountered: