fix compilation with nix 2.25

Author: Mic92

flake.lock

@@ -1,6 +1,9 @@
 {
   inputs = {
-    nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
+    # TODO: switch back once nix 2.25 hits nixpkgs-unstable
+    # https://nixpk.gs/pr-tracker.html?pr=355350
+    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable-small";
+    #nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
 
     flake-parts.url = "github:hercules-ci/flake-parts";
 
@@ -33,7 +36,7 @@
             callPackage
             stdenv
             ;
-          nix = nixVersions.nix_2_24;
+          nix = nixVersions.nix_2_25;
           llvmPackages = llvmPackages_16;
           nixf = callPackage ./libnixf { };
           nixt = callPackage ./libnixt { inherit nix; };

flake.nix

@@ -58,7 +58,7 @@ TEST_F(ValueTest, selectAttrPath) {
   nix::Value &Kern = selectStringViews(*State, Nested, {"c", "d"});
 
   ASSERT_EQ(Kern.type(), nix::ValueType::nInt);
-  ASSERT_EQ(Kern.integer(), 1);
+  ASSERT_EQ(static_cast<long int>(Kern.integer()), 1L);
 }
 
 } // namespace

libnixt/test/Value.cpp

@@ -54,8 +54,8 @@ std::optional<Location> locationOf(nix::PosTable &PTable, nix::Value &V) {
     return std::nullopt;
 
   Position LPos = {
-      .line = static_cast<int>(NixPos.line - 1),
-      .character = static_cast<int>(NixPos.column - 1),
+      .line = static_cast<long int>(NixPos.line - 1),
+      .character = static_cast<long int>(NixPos.column - 1),
   };
 
   return Location{
@@ -86,8 +86,8 @@ void fillUnsafeGetAttrPosLocation(nix::EvalState &State, nix::Value &V,
       Column.type() == nix::ValueType::nInt) {
 
     // Nix position starts from "1" however lsp starts from zero.
-    lspserver::Position Pos = {static_cast<int>(Line.integer()) - 1,
-                               static_cast<int>(Column.integer()) - 1};
+    lspserver::Position Pos = {static_cast<long int>(Line.integer()) - 1,
+                               static_cast<long int>(Column.integer()) - 1};
     Loc.range = {Pos, Pos};
   }
 }

nixd/lib/Eval/AttrSetProvider.cpp

@@ -127,12 +127,12 @@ bool fromJSON(const llvm::json::Value &, VersionedTextDocumentIdentifier &,
 
 struct Position {
   /// Line position in a document (zero-based).
-  int line = 0;
+  long int line = 0;
 
   /// Character offset on a line in a document (zero-based).
   /// WARNING: this is in UTF-16 codepoints, not bytes or characters!
   /// Use the functions in SourceCode.h to construct/interpret Positions.
-  int character = 0;
+  long int character = 0;
 
   friend bool operator==(const Position &LHS, const Position &RHS) {
     return std::tie(LHS.line, LHS.character) ==