From aa3e8693aba47b903a39e294884ca48d8d196b28 Mon Sep 17 00:00:00 2001 From: Floran Brutel Date: Thu, 7 Nov 2024 09:35:29 +0100 Subject: [PATCH] Fix issue with LightboxSpatieMediaLibraryImageEntry when no conversion is set --- src/Infolists/LightboxSpatieMediaLibraryImageEntry.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Infolists/LightboxSpatieMediaLibraryImageEntry.php b/src/Infolists/LightboxSpatieMediaLibraryImageEntry.php index 51ccdac..3713b91 100644 --- a/src/Infolists/LightboxSpatieMediaLibraryImageEntry.php +++ b/src/Infolists/LightboxSpatieMediaLibraryImageEntry.php @@ -41,7 +41,7 @@ protected function makeLightboxEntryFromMedia(Media $media): LightboxImageEntry if ($this->getVisibility() === 'private') { try { - if ($this->getConversion() && $media->hasGeneratedConversion($this->getConversion())) { + if (filled($this->getConversion()) && $media->hasGeneratedConversion($this->getConversion())) { $entry->state($media->getTemporaryUrl(now()->addMinutes(5), $this->getConversion())); } else { $entry->state($media->getTemporaryUrl(now()->addMinutes(5))); @@ -51,7 +51,7 @@ protected function makeLightboxEntryFromMedia(Media $media): LightboxImageEntry // This driver does not support creating temporary URLs. } } else { - if ($this->getConversion() && $media->hasGeneratedConversion($this->getConversion())) { + if (filled($this->getConversion()) && $media->hasGeneratedConversion($this->getConversion())) { $entry->state($media->getFullUrl($this->getConversion())); } else { $entry->state($media->getFullUrl());