Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider adding more GitHub actions #60

Closed
ccoVeille opened this issue May 7, 2024 · 4 comments
Closed

Please consider adding more GitHub actions #60

ccoVeille opened this issue May 7, 2024 · 4 comments

Comments

@ccoVeille
Copy link
Contributor

ccoVeille commented May 7, 2024 •
edited
Loading

I'm thinking about

  • launching test on PR

  • launching golangci-lint on PR

  • checking typos (avoid corrective PR like typos suggestion #59)

  • dependabot to make sure dependencies are up to date, but also that github actions are also kept up to date
@ccoVeille
Copy link
Contributor Author

I can help of course

@noahgorstein
Copy link
Owner

Yeah certainly! All of that would be great to add. And any help is much appreciated.

ccoVeille added a commit to ccoveille-forks/noahgorstein-jqp that referenced this issue May 9, 2024
@ccoVeille
Add GitHub actions for checking typos
de93b78 
The tool used is https://github.com/crate-ci/typos

Related to noahgorstein#60
@ccoVeille ccoVeille mentioned this issue May 9, 2024
Merged
ccoVeille added a commit to ccoveille-forks/noahgorstein-jqp that referenced this issue May 9, 2024
@ccoVeille
Add GitHub actions for checking typos
8201961 
The tool used is https://github.com/crate-ci/typos

Related to noahgorstein#60
ccoVeille added a commit to ccoveille-forks/noahgorstein-jqp that referenced this issue May 9, 2024
@ccoVeille
Add dependabot to GitHub Action
27a8d54 
It will help to keep go dependencies (go.mod) up to date, but also will
make sure GitHub actions are also updated.

Related to noahgorstein#60
ccoVeille added a commit to ccoveille-forks/noahgorstein-jqp that referenced this issue May 9, 2024
@ccoVeille
Add Continuous Integration to GitHub actions
e59c730 
go test is launched, then golangci-lint is launched

Related to noahgorstein#60
This was referenced May 9, 2024
Merged
Merged
@ccoVeille
Copy link
Contributor Author

I made #62, #63 and #64

@noahgorstein
Copy link
Owner

@ccoVeille Really appreciate all your contributions in this area! The project's health (and myself) thank you 😄 . Think this will make future contributions much easier to review and give us some more confidence when we add some tests that no regressions are being introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccoVeille @noahgorstein