Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exposure analysis] remove ExternalExposure from the PolicyExposureWithoutSelectors #488

Closed
shireenf-ibm opened this issue Jan 27, 2025 · 0 comments · Fixed by #490
Closed
Assignees

Comments

@shireenf-ibm
Copy link
Contributor

  • external-exposure is actually computed and generated using the IPBlock Peer and the ExternalExposure field of the PolicyExposureWithoutSelectors struct is actually not used in the exposure-analysis so better to remove it to have more clean code
  • mention in documentation that exposure analysis struct only computes exposure to entire-cluster (for external ip-blocks just copying the conn-list results).
@shireenf-ibm shireenf-ibm self-assigned this Jan 27, 2025
@adisos adisos changed the title remove ExternalExposure from the PolicyExposureWithoutSelectors [exposure analysis] remove ExternalExposure from the PolicyExposureWithoutSelectors Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants