Skip to content

Commit 0b5416c

Browse files
committed
[#5280] Review feedback: do not force save on save-exact
1 parent 0b07587 commit 0b5416c

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

workspaces/config/lib/definitions/definitions.js

-3
Original file line numberDiff line numberDiff line change
@@ -1827,9 +1827,6 @@ define('save-exact', {
18271827
version rather than using npm's default semver range operator.
18281828
`,
18291829
flatten (key, obj, flatOptions) {
1830-
if (obj[key]) {
1831-
flatOptions.save = true
1832-
}
18331830
// just call the save-prefix flattener, it reads from obj['save-exact']
18341831
definitions['save-prefix'].flatten('save-prefix', obj, flatOptions)
18351832
},

workspaces/config/test/definitions/definitions.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -814,11 +814,10 @@ t.test('save-exact', t => {
814814
'save-exact': true,
815815
'save-prefix': '~1.2.3',
816816
}
817-
let flat = {}
817+
const flat = {}
818818
mockDefs()['save-exact']
819819
.flatten('save-exact', { ...obj, 'save-exact': true }, flat)
820-
t.strictSame(flat, { savePrefix: '', save: true })
821-
flat = {}
820+
t.strictSame(flat, { savePrefix: '' })
822821
mockDefs()['save-exact']
823822
.flatten('save-exact', { ...obj, 'save-exact': false }, flat)
824823
t.strictSame(flat, { savePrefix: '~1.2.3' })

0 commit comments

Comments
 (0)