Skip to content

Commit

Permalink
fix(core): do not warn about custom tasks runners when explicitly usi… (
Browse files Browse the repository at this point in the history
#29669)

…ng default<!-- Please make sure you have read the submission guidelines
before posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
AgentEnder authored Jan 21, 2025
1 parent ee135b2 commit 104f06c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@
"nxCloudId": "62d013ea0852fe0a2df74438",
"nxCloudUrl": "https://staging.nx.app",
"parallel": 1,
"bust": 1,
"bust": 2,
"defaultBase": "master",
"conformance": {
"rules": [
Expand Down
10 changes: 7 additions & 3 deletions packages/nx/src/tasks-runner/run-command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -912,8 +912,12 @@ export function getRunnerOptions(

return result;
}

function isCustomRunnerPath(modulePath: string) {
return !['nx-cloud', '@nrwl/nx-cloud', defaultTasksRunnerPath].includes(
modulePath
);
return ![
'nx-cloud',
'@nrwl/nx-cloud',
'nx/tasks-runners/default',
defaultTasksRunnerPath,
].includes(modulePath);
}

0 comments on commit 104f06c

Please sign in to comment.