Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): add conventional commits configurability for version and changelog #22004
feat(release): add conventional commits configurability for version and changelog #22004
Changes from 24 commits
1552a77
a91972c
8eaf11b
1a73168
dc51bf2
ba4befa
097ff3c
33bd461
8f40cd3
c9fcbbf
600f7a3
4410360
d5c6891
31cfabf
dd804eb
b299510
078fefc
8c058d3
4f3b6b3
25d49c1
f8a2e33
b144373
a5d08ab
8a13ce3
390ef38
777c361
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like it to be made clearer that this is an advanced case and that most folks are perfectly fine/happy with the default behavior and no configuration should be required for most people (i.e. should just be
"conventionalCommits": true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add something about this being an advanced use case, but I want to point out that the
release.conventionalCommits
property they are setting here is different than the existingrelease.version.conventionalCommits
property that is frequently set totrue
to enable it for versioning. Most users will never setrelease.conventionalCommits
, as its only valid value is an advanced config option outlined in this doc. It is invalid (and meaningless) forrelease.conventionalCommits
to be set totrue
.The reason there are two different properties is because this new one affects both
version
andchangelog
commands, so it didn't make sense to extend the existingrelease.version.conventionalCommits
property to accept a configuration object.