Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example notebooks are broken #67

Closed
2 of 3 tasks
mpacer opened this issue Jul 30, 2018 · 1 comment
Closed
2 of 3 tasks

Example notebooks are broken #67

mpacer opened this issue Jul 30, 2018 · 1 comment
Labels

Comments

@mpacer
Copy link
Member

mpacer commented Jul 30, 2018

Right now, our _html_repr_ is not handling a couple of our features:

  • Boolean key-value pairs (all values are treated as strings meaning you cannot define <video controls><source src='…'></video> as opposed to <video ><source src='…'></video> )
  • DOM style css keys don't work in style attribute blocks (inline style info needs to be defined with css-style names)
  • Updating existing display objects does not work since we changed VDOM objects to be immutable; this breaks the last examples in exploring-elements.ipynb

I've got a PR to fix the first two but the last one is more of a design decision on how we want to support updated displays of vdom objects.

@rgbkrk @yuvipanda

@willingc
Copy link
Member

#68 fixes the first two items. Third item moved to #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants