Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-session is not thread-safe #30

Open
mainTAP opened this issue Nov 9, 2018 · 0 comments
Open

Multi-session is not thread-safe #30

mainTAP opened this issue Nov 9, 2018 · 0 comments

Comments

@mainTAP
Copy link

mainTAP commented Nov 9, 2018

Hello,

Firstly I would like to thank you for the multi-sessions feature.
Unfortunately the multi session capability is not quite thread safe and one can end up sending API calls using a header from another session. Which seems to be due to the shared session_stack.

As a workaround one can use use threading lock to limit one vspk call at a time, but this blocks until the response to the call is received. To minimise the blocking time, I am currently using asynchronous calls and only lock the "call send" ( maily the API call header generation I suppose ) .

It would be nice if the multi-session synchronous calls could be used thread safely.

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant