-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put images related to Visualisation & Data Science tab under Ecosystem Section in a separate folder. #484
Comments
This is the directory : https://github.com/numpy/numpy.org/tree/master/static/images/content_images |
Fair point, Vivek! @joelachance @rgommers Are there any reasons against putting images for each of the two tabs (Visualization & Data Science) in separate folders? |
Not that I can think of. A PR to move them would be great. |
@InessaPawson folders have to be given names for sure which has to be decided ... Not sure whether @MarsBarLee had anything to do with this or not ... Because as far as I have observed she has been the central creator/decision maker as far as Scientific Tab was concerned ... |
It might simplify things to just have a single images directory. It would probably have 20-30 images tops, but IMO you'll never wonder where the images live :) I'm not sure we have enough images for sub directories. |
More icons were needed for "scientific domain" as the tab developed over time (14 icons to be exact) Visualization Tab have around 7-9 images at the present moment (while I strongly feel it is not yet as developed as the Scientific Tab is) Have explained the structure of the two tabs in detail here : (link below), just in case that may be relevant. |
@new-vivek11 thanks! |
@joelachance if everyone else thinks the same that where images are put (in other words organising images into respective folders) does not really matter a lot ... I am okay with that too ... This issue can be closed then. |
Images that are related to the Science Tab under the Ecosystem Section are in one separate folder.
but the images that are related to Visualization Tab are not in one separate folder.
this will related to #342 too as @InessaPawson has described the 3 main issues there : Science Tab (which is almost done), Data Science Tab, Visualization Tab.
LITTLE UPDATE ...
The whole directory of content-images (link given below) contains images - some tabs have their own separate folders, other tabs do not have their own folders - like Visualization and Data Science.
The text was updated successfully, but these errors were encountered: