Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summarize_detections produces incorrect values in num_locs and locations columns #182

Closed
trbinder opened this issue Sep 12, 2023 · 3 comments

Comments

@trbinder
Copy link
Collaborator

Screen Shot 2023-09-12 at 13 19 42 PM

There appears to be a bug in the code that cause the location_col argument character string to be displayed in the locations column rather than a summary of locations that each fish was detected. This occurs when summ_type = "location" or "animal".

@chrisholbrook chrisholbrook changed the title locations column in output for summarize_detetecions displaying the location_col argument rather than a summary of locations locations column in output for summarize_detections displaying the location_col argument rather than a summary of locations Feb 25, 2024
@chrisholbrook
Copy link
Collaborator

Fixed in glatos 0.7.2 (commit 3f0a2ee ).

@chrisholbrook chrisholbrook reopened this Apr 9, 2024
@chrisholbrook chrisholbrook changed the title locations column in output for summarize_detections displaying the location_col argument rather than a summary of locations summarize_detections produces incorrect values in num_locs and locations columns Apr 9, 2024
@chrisholbrook
Copy link
Collaborator

New but related issue, likely side effect of commit 3f0a2ee ):

e.g., example code (from help("summarize_detections")), produces incorrect results:

# get path to example detection file
det_file <- system.file("extdata", "walleye_detections.csv",
                                    package = "glatos")

det <- read_glatos_detections(det_file)

# Basic summary by animal
ds <- summarize_detections(det, summ_type = "animal")

ds

image

Should look like this:

image

@chrisholbrook
Copy link
Collaborator

Fixed in glatos 0.7.3 (commit f455938).

Reiterates #220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants