Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a machine is occupied, show the ocf account name of the logged in user #8

Closed
MrMinos opened this issue Feb 24, 2019 · 10 comments
Closed

Comments

@MrMinos
Copy link
Member

MrMinos commented Feb 24, 2019

This would be useful for opstaff who needs to refund pages. Maybe should limit showing the account names only to ocf ip address range?

@dkess
Copy link
Member

dkess commented Feb 24, 2019

This would be a pretty big privacy issue, I think it's fine to just have users self-report their username. We could also build this into the paper refund command (refund pages to user at machine) though I think it's equally annoying to find out the name of a desktop a user is on...

@cg505
Copy link
Member

cg505 commented Feb 24, 2019

Maybe we could just print out a map for opstaff desk and then let opstaff use last-lab.

@MrMinos
Copy link
Member Author

MrMinos commented Feb 24, 2019

Hmmm aside from privacy issue since we can just limit access to opstaff desk; this may not be a big enough problem to solve, but having this would help with opstaff UX.

Come to think of it, maybe make the each machine on the map clickable and enable refund for the current logged in user?

@raymondnumbergenerator
Copy link
Member

I think the thing is if a user comes up to opstaff asking for page refunds it's easier for the user to just state their username than to point out which machine they're logged in to.

I also agree with dkess about this being a privacy issue.

@MrMinos
Copy link
Member Author

MrMinos commented Mar 4, 2019

I think the thing is if a user comes up to opstaff asking for page refunds it's easier for the user to just state their username than to point out which machine they're logged in to.

I agree on that it's likely the case when the username is short; also with long usernames maybe opstaff don't find it much of a hassle. It's a nice-to-have and a step towards a graphical solution for opstaff paper refund as mentioned here.

Also why is it actually a privacy issue if we limit access to only ocf ip range, or limit to opstaff/ocfstaff group?

@dkess
Copy link
Member

dkess commented Mar 4, 2019

It's fine if we limit such a feature to opstaff/ocfstaff group, though writing a mechanism to enforce these permissions is harder, especially since I'd like this webapp to not rely on other parts of OCF infra. Doing this kind of security based on IP addresses is not acceptable.

@TonyLianLong
Copy link
Member

Is ncurses a possibility since it is graphical and hence easier to use? We don’t need to use labmap to do everything.

@dkess
Copy link
Member

dkess commented Mar 4, 2019

I wouldn't expect opstaff refunding pages to want to use such an interface. I think the "best" way to do this would be to somehow make a second version of this webapp that makes calls to another API for seeing who is on a desktop. That API would have to take Kerberos/LDAP authentication to be used.

This leaves a lot of questions unanswered though, and it's a lot of infra to build out for a feature I don't think we'd end up using.

@MrMinos
Copy link
Member Author

MrMinos commented Mar 4, 2019

I agree it's a marginal enhancement, but you never know. Maybe worth asking in opstaff meeting.

@MrMinos
Copy link
Member Author

MrMinos commented Mar 16, 2019

After talking to opstaff–Esha, a new take on this GitHub issue came up.

Most of the times, when users approach the opstaff for a refund, they've already sent the print job and logged out of the computer, only to find that their print job is missing/rejected. So viewing the currently logged in user on the labmap won't help with majority of the refund request cases.

This was an amusing find, to learn that the real situation lies outside of the imagination.

Closing the issue with concerns of privacy and it won't help the opstaff as much due to the description above of how things go down in real life.

@MrMinos MrMinos closed this as completed Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants