Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metallb code enhancements #54

Open
yussufsh opened this issue Aug 7, 2023 · 1 comment
Open

metallb code enhancements #54

yussufsh opened this issue Aug 7, 2023 · 1 comment
Assignees
@Shilpa-Gokul

Comments

@yussufsh
Copy link
Contributor

yussufsh commented Aug 7, 2023

wrt #53 we will need more code improvements after the merge.

  1. Reuse (e2e file is too long)
  2. Use namespace as a variable
  3. Prefix all variables with metalb_
  4. etc.
@Shilpa-Gokul Shilpa-Gokul mentioned this issue Aug 7, 2023
Merged
@yussufsh yussufsh reopened this Aug 14, 2023
@yussufsh
Copy link
Contributor Author

/assign @Shilpa-Gokul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shilpa-Gokul Shilpa-Gokul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yussufsh @Shilpa-Gokul