Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python refactoring options deactivated when extension is activated #78

Open
mathisgauthey opened this issue May 24, 2024 · 3 comments
Open

Comments

@mathisgauthey
Copy link

Hi there.

Just found out that when using your extension, the python extract refactoring stops working. I don't know why, but this is really important in my workflow, and I don't think this is happening on the PyCharm extension.

Thanks in advance !

@trinhanhngoc
Copy link
Member

Hello @mathisgauthey ,

This is a known limitation. Some refactoring features are only available when using the default Python language server (Pylance). Because the Pylance language server is not extensible, I must build a new language server for Odoo, which is currently missing some features from Pylance.

@mathisgauthey
Copy link
Author

Hello @mathisgauthey ,

This is a known limitation. Some refactoring features are only available when using the default Python language server (Pylance). Because the Pylance language server is not extensible, I must build a new language server for Odoo, which is currently missing some features from Pylance.

Thanks for the answer. I noticed that removing the "python.languageServer": "None", allows to get the Pylance refactor options while preserving the vscode-odoo auto completion and features. I just get a few unresolved imports from pylance, which is normal, but it allows to benefir from such a feature.

Would it be possible to allow for an option to prevent vscode-odoo from adding this line to settings.json ?

@trinhanhngoc
Copy link
Member

@mathisgauthey ,

OK. I will consider adding that option to the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants