Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRIT] Vao/Buffer state can be corrupted #141

Open
eXponenta opened this issue May 27, 2022 · 0 comments
Open

[CRIT] Vao/Buffer state can be corrupted #141

eXponenta opened this issue May 27, 2022 · 0 comments

Comments

@eXponenta
Copy link
Contributor

if (this.gl.renderer.currentGeometry !== `${this.id}_${program.attributeOrder}`) {

When we bind VAO or unbind it we should and change renderer.currentGeometry, this is IMPORTANT because some code call only bindVertexArray.

See:
https://github.com/oframe/ogl/blob/master/src/extras/GLTFLoader.js#L92

Because we have a VAO Abstraction, why we can't store it in renderer.currentGeometry inside renderer?
This is more strictly that store string literal.

Then need move currentGeometry to state.

@eXponenta eXponenta changed the title [CRIT] Vao state can be unbound, but geometry linkage will alive [CRIT] Vao/Buffer state can be corrupted May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant