Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image scaling not functional, SVG disaster, %% problem #318

Closed
keerah opened this issue May 26, 2023 · 10 comments
Closed

Image scaling not functional, SVG disaster, %% problem #318

keerah opened this issue May 26, 2023 · 10 comments

Comments

@keerah
Copy link

keerah commented May 26, 2023

Image scale tags like ![[img.jpg|200]] have no effect now.
Most of the SVGs destroy formatting and scramble pages to unreadable state.
%% symbols inside the single line code blocks erase content (down to the next %% I guess).
My digital garden is mostly destroyed now :(

@keerah
Copy link
Author

keerah commented May 26, 2023

I rolled back to template v 1.49.0 and plugin v 2.44.0, this is the last version where image scaling worked, except SVGs

@oleeskild
Copy link
Owner

I've not yet looked at the %% issue, but I think I've managed to fix both the scaling issue and the "svg disaster". Could you try to update to the latest template and see if it works in your case as well?

@keerah
Copy link
Author

keerah commented May 26, 2023

Thank you! Image scaling is back, except SVG scaling.
SVGs inside notes still kill formatting.
(it happens after rebuilding a note, old notes are ok)
SVG favicon still leads to template build failure.

@keerah
Copy link
Author

keerah commented May 27, 2023

Regarding the SVGs breaking formatting. The culprit is the SVGs file format.
SVG files saved by the Diagrams plugin (draw-io) break the formatting, although it didn't happen before, and any other software and browsers open them with no problem.
This is an example SVG file that breaks formatting. The difference that I can see is the absence of the initial line containing the xml specification and doctype <?xml version="1.0" encoding="UTF-8" standalone="no"?><!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">. SVGs with this line present do not break things.
SVG scaling still doesn't work as of template version 1.53.1.

@keerah
Copy link
Author

keerah commented Jul 9, 2023

No hope for SVG scaling fix?

@oleeskild oleeskild reopened this Jul 9, 2023
@oleeskild
Copy link
Owner

I've added a fix for it in the latest version of the plugin. Let me know if the latest version fixes your issue @keerah!

@keerah
Copy link
Author

keerah commented Jul 10, 2023

Thank you, but it doesn't seem to work unfortunately.
But, I can see it definitely tries to crop svgs to that size, instead of scaling
Screenshot 2023-07-09 223540

@oleeskild
Copy link
Owner

Hmm, okay, it worked with the last example you gave, but appearently not that one. Could you send the svg file in the image above, and I'll try to figure out whats going wrong.

julesvirallinen pushed a commit to julesvirallinen/obsidian-digital-garden that referenced this issue Aug 21, 2023
@oleeskild oleeskild moved this to 👀 Ready for release in Obsidian Digital Garden Status Oct 27, 2023
@oleeskild
Copy link
Owner

I've managed to fix the SVG issues in the latest release. Please update to the latest version of the plugin and re-publish the sites with the broken SVGs. They should now work as expected.

@github-project-automation github-project-automation bot moved this from 👀 Ready for release to ✅ Released in Obsidian Digital Garden Status Oct 27, 2023
@oleeskild
Copy link
Owner

I've opened a new issue regarding the %% issue here #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

No branches or pull requests

2 participants