Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring to use tibbles instead of data-frames or arrays #9

Open
BarbaraRobson opened this issue Nov 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@BarbaraRobson
Copy link
Collaborator

Tibbles and hyper-tibbles are computationally more efficient and easier to display.

@BarbaraRobson BarbaraRobson added the enhancement New feature or request label Nov 21, 2022
@dbarneche
Copy link
Contributor

Is there a specific reason or this? This would add yet another dependency to the repo... would you gain speed?

@BarbaraRobson
Copy link
Collaborator Author

I don't think it would add a dependency because the repo already relies on dplyr, which uses tibbles (part of the tidyverse).

Advantages of tibbles:

  • Faster in some circumstances that data frames (but may not make much difference for this package -- I am not sure).
  • Where I have used arrays, using tibbles instead would support refactoring the code to make it easier to read. E.g. using tidy dplyr and purrr functions instead of "apply" and "lapply".

It isn't the first priority, but coding efficiently with multi-dimensional arrays hurts my brain and is where errors are most likely to creep in. I started this project before I was aware of dplyr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants