Update the parameter names in LoggerProvider::GetLogger #2689
Labels
bug
Something isn't working
good first issue
Good for newcomers
help wanted
Good for taking. Extra help will be provided by maintainers
triage/accepted
Indicates an issue or PR is ready to be actively worked on.
The following spec says
name
andversion' for "Get a Logger" in
LoggerProvider, but they are named as
library_nameand
library_version` in the OpenTelemetry C++ API (see the second link below). Could the parameter names be updated to be consistent with the spec which could reduce confusion for the users coming from spec or SDK from other languages?https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/bridge-api.md#get-a-logger
https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry/logs/logger_provider.h#L48
This is based on #2680 (comment).
The text was updated successfully, but these errors were encountered: