Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the parameter names in LoggerProvider::GetLogger #2689

Open
ThomsonTan opened this issue May 31, 2024 · 3 comments
Open

Update the parameter names in LoggerProvider::GetLogger #2689

ThomsonTan opened this issue May 31, 2024 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ThomsonTan
Copy link
Contributor

The following spec says name and version' for "Get a Logger" in LoggerProvider, but they are named as library_nameandlibrary_version` in the OpenTelemetry C++ API (see the second link below). Could the parameter names be updated to be consistent with the spec which could reduce confusion for the users coming from spec or SDK from other languages?

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/bridge-api.md#get-a-logger

https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry/logs/logger_provider.h#L48

This is based on #2680 (comment).

@ThomsonTan ThomsonTan added the bug Something isn't working label May 31, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 31, 2024
@esigo esigo added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 3, 2024
@ThomsonTan ThomsonTan self-assigned this Jun 3, 2024
@ThomsonTan
Copy link
Contributor Author

Reviewed the GetTracer API. The same issue is not there. @lalitb thanks for the reminder.

virtual nostd::shared_ptr<Tracer> GetTracer(nostd::string_view name,

Copy link

github-actions bot commented Aug 5, 2024

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Aug 5, 2024
@marcalff marcalff added help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Feb 18, 2025
Copy link

This issue is available for anyone to work on. Make sure to reference this issue in your pull request.
✨ Thank you for your contribution! ✨

@github-actions github-actions bot removed the Stale label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants