Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Cmake option WITH_OTLP_GRPC_SSL_MTLS_PREVIEW is hidden #2700

Closed
marcalff opened this issue Jun 13, 2024 · 0 comments · Fixed by #2714
Closed

[BUILD] Cmake option WITH_OTLP_GRPC_SSL_MTLS_PREVIEW is hidden #2700

marcalff opened this issue Jun 13, 2024 · 0 comments · Fixed by #2714
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

The build supports compiling with WITH_OTLP_GRPC_SSL_MTLS_PREVIEW, per api/CMakeLists:

if(WITH_OTLP_GRPC_SSL_MTLS_PREVIEW)
  target_compile_definitions(opentelemetry_api
                             INTERFACE ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW)
endif()

The problem is that this option, WITH_OTLP_GRPC_SSL_MTLS_PREVIEW, is not defined in the top level CMakeLists.txt.

When using ccmake, the UI does not expose this choice.
@marcalff marcalff added the bug Something isn't working label Jun 13, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 13, 2024
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 17, 2024
@owent owent mentioned this issue Jun 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Add option WITH_OTLP_GRPC_SSL_MTLS_PREVIEW owent/opentelemetry-cpp
1 participant
@marcalff