Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Spurious test failures #3232

Closed
marcalff opened this issue Jan 8, 2025 · 0 comments · Fixed by #3233
Closed

[CI] Spurious test failures #3232

marcalff opened this issue Jan 8, 2025 · 0 comments · Fixed by #3233
Assignees
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

marcalff commented Jan 8, 2025

Very often, the CI on windows fails and returns an non 0 return code to the github worker.

For example:

CMake exporter proto (Build as DLL)

run cmake test (DLL build)
./ci/do_ci.ps1 cmake.dll.test

end with:

Error: Process completed with exit code 1.

Note that the CI runs the example code, as in:

    examples\simple\Debug\example_simple.exe
    $exit = $LASTEXITCODE
    if ($exit -ne 0) {
      exit $exit
    }
    examples\metrics_simple\Debug\metrics_ostream_example.exe
    $exit = $LASTEXITCODE
    if ($exit -ne 0) {
      exit $exit
    }
    examples\logs_simple\Debug\example_logs_simple.exe
    $exit = $LASTEXITCODE
    if ($exit -ne 0) {
      exit $exit
    }

and failures happen after the example code is executed (it prints output visible in the logs).

Root cause:

main() do not return a proper value.

For example in examples/simple/main.cc:

int main()
{
  // Removing this line will leave the default noop TracerProvider in place.
  InitTracer();

  foo_library();

  CleanupTracer();
}
@marcalff marcalff added the bug Something isn't working label Jan 8, 2025
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 8, 2025
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jan 8, 2025
@marcalff marcalff self-assigned this Jan 8, 2025
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant