Fix race condition in ConcurrentMultiSpanProcessor.shutdown() #4462
+77
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomcgi
force-pushed
the
fix-4461/concurrent-multi-span-processor
branch
from
b432fb2 to
bfbab3a
Compare
Fixed error during shutdown: 'cannot schedule new futures after shutdow'. Modified shutdown sequence to handle executor already being in shutdown state. Added direct processor shutdown when executor is unavailable. Added regression test for executor shutdown race condition.
jomcgi
force-pushed
the
fix-4461/concurrent-multi-span-processor
branch
from
bfbab3a to
9d45683
Compare
jomcgi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed error during shutdown: 'cannot schedule new futures after shutdow'.
Modified shutdown sequence to handle executor already being in shutdown state.
Added direct processor shutdown when executor is unavailable.
Added regression test for executor shutdown race condition.
Fixes #4461
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e test-opentelemetry-sdkDoes This PR Require a Contrib Repo Change?
Checklist: