Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require attributes and event fields to have stability #564

Open
lmolkova opened this issue Jan 22, 2025 · 3 comments
Open

Require attributes and event fields to have stability #564

lmolkova opened this issue Jan 22, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@lmolkova
Copy link
Contributor

See open-telemetry/semantic-conventions#1777 - we don't validate that stability is present on attributes or event fields

@lmolkova lmolkova added the bug Something isn't working label Jan 22, 2025
@lmolkova lmolkova moved this to To consider for the next release in OTel Weaver Project Jan 22, 2025
@jsuereth jsuereth moved this from To consider for the next release to Next Release in OTel Weaver Project Jan 22, 2025
@jerbly
Copy link
Contributor

jerbly commented Jan 22, 2025

@lmolkova looks like we're also not enforcing stability on enum members of event fields: https://github.com/open-telemetry/semantic-conventions/blob/main/model/device/events.yaml#L36

I assume we want this fixed too?

@lmolkova
Copy link
Contributor Author

@jerbly great catch! yes, explicit stability everywhere it matters is the goal :)

@jerbly
Copy link
Contributor

jerbly commented Jan 22, 2025

At the moment the Weaver code, EBNF and semconv.schema.json all define the body of the event as an any_value. Some any_values can contain any_values. Therefore the body itself is required to have stability defined. This is missing in every use of body in the current semconvs.

    body:
      id: device_lifecycle_state
      type: map
      requirement_level: required
      stability: experimental # <-------------- This is also required
      fields:
        - id: ios.state
          stability: experimental
          type: enum
          ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Next Release
Development

No branches or pull requests

2 participants