feat: dragHandle menu #163
Open
+127
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Debbl is attempting to deploy a commit to the OpenBuild Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ourai
requested changes
Mar 13, 2025
|
|
||
| const getDragHandlePos = (editor: EditorInstance) => { | ||
| const { left, top } = refs.reference.current!.getBoundingClientRect(); | ||
| const posAtCoords = editor.view.posAtCoords({ left: left + 50, top: top + 1 }); |
There was a problem hiding this comment.
这 50 和 1 的含义是什么？最好通过语义化变量命名或注释（英文）说明下
| @@ -35,6 +35,7 @@ | |||
| "@bytemd/react": "^1.21.0", | |||
| "@ethersproject/address": "^5.7.0", | |||
| "@ethersproject/units": "^5.7.0", | |||
| "@floating-ui/react": "^0.27.5", | |||
| function DragHandle() { | ||
| const { editor } = useEditor(); | ||
|
|
||
| const [isOpen, setIsOpen] = useState(false); |
There was a problem hiding this comment.
用 open 和 setOpen 即可，「is-」开头一般会是用在返回布尔值的函数命名：https://ntks.ourai.ws/guides/javascript-coding-style/
| import type { EditorInstance} from 'novel'; | ||
| import type { ReactNode } from 'react'; | ||
|
|
||
| function Item({ children, onClick }: { children: ReactNode; onClick: () => void }) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #160
eslint-plugin-unused-imports更新一下版本，不清楚什么原因和 typescript-eslint 一起还是有问题insertNewBlockBelow和deleteBlock方法，先通过getDragHandlePos找到 dragHandle 所在的 pos 再进行操作，之前只是对 selection 的操作，有时候会有问题，dragHanle 的 selection 的位置不一致