From 4a4fad7a1f4498ea6c6b4953cb74bbe6eb49c106 Mon Sep 17 00:00:00 2001
From: TheCartpenter <scoutch@gmail.com>
Date: Fri, 19 Jan 2024 19:12:00 -0500
Subject: [PATCH] Testing responseHash from firstdata payment

---
 upload/catalog/model/extension/payment/firstdata.php | 10 +++++-----
 upload/catalog/model/extension/payment/opayo.php     |  5 +----
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/upload/catalog/model/extension/payment/firstdata.php b/upload/catalog/model/extension/payment/firstdata.php
index 1ec6b8514..4d113a0fb 100644
--- a/upload/catalog/model/extension/payment/firstdata.php
+++ b/upload/catalog/model/extension/payment/firstdata.php
@@ -169,12 +169,12 @@ public function storeCard(string $token, int $customer_id, string $month, string
 	/**
 	 * responseHash
 	 *
-	 * @param float     $total
-	 * @param string    $currency
-	 * @param \Datetime $txn_date
-	 * @param string    $approval_code
+	 * @param float  $total
+	 * @param string $currency
+	 * @param string $txn_date
+	 * @param string $approval_code
 	 */
-	public function responseHash(float $total, string $currency, \Datetime $txn_date, $approval_code) {
+	public function responseHash(float $total, string $currency, string $txn_date, string $approval_code) {
 		$tmp = $total . $this->config->get('payment_firstdata_secret') . $currency . $txn_date . $this->config->get('payment_firstdata_merchant_id') . $approval_code;
 		$ascii = bin2hex($tmp);
 
diff --git a/upload/catalog/model/extension/payment/opayo.php b/upload/catalog/model/extension/payment/opayo.php
index 31e4f7df4..d396a94ae 100644
--- a/upload/catalog/model/extension/payment/opayo.php
+++ b/upload/catalog/model/extension/payment/opayo.php
@@ -447,8 +447,6 @@ public function cronPayment(): array {
 	 * @param string               $recurring_expiry
 	 * @param int                  $recurring_frequency
 	 * @param mixed|null           $i
-	 * @param int                  $subscription_id
-	 * @param string               $subscription_name
 	 *
 	 * @return array<string, mixed>
 	 */
@@ -662,7 +660,6 @@ private function getProfiles(): array {
 	 * Get Profile
 	 *
 	 * @param int $order_recurring_id
-	 * @param int $subscription_id
 	 *
 	 * @return array<string, mixed>
 	 */
@@ -729,7 +726,7 @@ public function sendCurl(string $url, array $payment_data, $i = null): array {
 	 * Log
 	 *
 	 * @param string  $title
-	 * @param mixed   $data
+	 * @param ?string $data
 	 *
 	 * @return void
 	 */