Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Mutable" no longer being used #140

Closed
3 tasks
sarina opened this issue Dec 4, 2013 · 7 comments
Closed
3 tasks

"Mutable" no longer being used #140

sarina opened this issue Dec 4, 2013 · 7 comments
Assignees

Comments

@sarina
Copy link
Contributor

sarina commented Dec 4, 2013

In fields.py class Field we have a property MUTABLE which was originally created for bulk save logic.

My understanding is that this property is no longer being used with @cpennington's changes to XBlock save logic. If this is the case, we should strip out all references to MUTABLE within XBlock.

Thanks @dmitchell for noting this.

Acceptance Criteria:

  • Make sure MUTABLE is no longer used.
  • Strip out all references to MUTABLE within XBlock.
  • Install the Xblock as a package on some customized Xblock and make sure everything is working fine
@feanil feanil moved this to 📋 Backlog in Aximprovements Team Dec 19, 2023
@feanil feanil moved this from 📋 Backlog to 🔖 Ready in Aximprovements Team Dec 19, 2023
@farhan
Copy link
Contributor

farhan commented Jan 30, 2024

@sarina @cpennington It would be great if you could add the PR link related to the XBlock save logic change. It will help to understand the ticket in detail.
cc: @feanil

@sarina
Copy link
Contributor Author

sarina commented Jan 30, 2024

Boy, this ticket is 11 years old and I don't recall what it's about anymore 😅 also Cale has left the Open edX project. Hopefully @feanil can help you a bit more.

@feanil
Copy link
Contributor

feanil commented Feb 6, 2024

Looking at the code, it looks like the MUTABLE property is indeed never referenced for decision making within the xblock repo. @farhan to complete this work. Make sure the MUTABLE property is not being referenced by any runtimes in edx-platform and if that is the case, we should be able to remove the property and release a new version of this repo.

@salman2013 salman2013 self-assigned this Mar 11, 2024
@salman2013 salman2013 moved this from 🔖 Ready to 🏗 In progress in Aximprovements Team Mar 11, 2024
@salman2013
Copy link
Contributor

@feanil I did not find MUTABLE property referenced by any runtime in edx-platform.
There is a condition in XBlock but i am not sure if should we remove it.

@feanil
Copy link
Contributor

feanil commented Mar 19, 2024

I think given that it is not actually set anywhere, we can just remove it and choose the default branch of any conditionals.

@salman2013
Copy link
Contributor

@feanil I have created PR for it. #727

@salman2013
Copy link
Contributor

After discussion on the PR of this ticket, We found that there might be a memory usage implication for this change. It may produce more copies of the defaults than we want for certain objects. We decided to keep this code as it is and close this issue.

@salman2013 salman2013 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Aximprovements Team Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants