-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Mutable" no longer being used #140
Comments
@sarina @cpennington It would be great if you could add the PR link related to the |
Boy, this ticket is 11 years old and I don't recall what it's about anymore 😅 also Cale has left the Open edX project. Hopefully @feanil can help you a bit more. |
Looking at the code, it looks like the |
I think given that it is not actually set anywhere, we can just remove it and choose the default branch of any conditionals. |
After discussion on the PR of this ticket, We found that there might be a memory usage implication for this change. It may produce more copies of the defaults than we want for certain objects. We decided to keep this code as it is and close this issue. |
In fields.py class
Field
we have a propertyMUTABLE
which was originally created for bulk save logic.My understanding is that this property is no longer being used with @cpennington's changes to XBlock save logic. If this is the case, we should strip out all references to
MUTABLE
within XBlock.Thanks @dmitchell for noting this.
Acceptance Criteria:
MUTABLE
is no longer used.MUTABLE
within XBlock.The text was updated successfully, but these errors were encountered: