Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adaptation for the Course Authoring problems structure #33693

Conversation

Inferato
Copy link
Contributor

Description

This is a backport MR to the master branch.

Course Authoring provides a new way to problem creation. However, it has a slightly different XML structure and that affects the Problem Response report content:
изображение

Deadline

None

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 10, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 10, 2023

Thanks for the pull request, @Inferato!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 13, 2023
@mphilbrick211
Copy link

Hi @Inferato! Flagging a failing check here - would you mind taking a look?

@connorhaugh
Copy link
Contributor

We should maybe look at implementing a solution in frontend-lib-content-components as opposed to here on the backend.

@mphilbrick211
Copy link

We should maybe look at implementing a solution in frontend-lib-content-components as opposed to here on the backend.

@Inferato - flagging this for you!

@mariajgrimaldi
Copy link
Member

Hi there @Inferato! We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against quince.master once that happens. Also, you should take a look at Connor's suggestion above. Thanks!

@cmltaWt0 cmltaWt0 added product review PR requires product review before merging and removed product review PR requires product review before merging labels Feb 6, 2024
@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Mar 3, 2025
@mphilbrick211
Copy link

Closing due to inactivity. Can reopen in the future if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
Status: Backlog
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants