-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: styles for share video functionality of the video xblock #34808
base: master
Are you sure you want to change the base?
fix: styles for share video functionality of the video xblock #34808
Conversation
Thanks for the pull request, @ihor-romaniuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @ihor-romaniuk! This should get reviewed by Product. Flagging for @jmakowski1123! |
f204d92
to
552fb3a
Compare
07047bb
to
7bc74fb
Compare
@jmakowski1123 does this have a roadmap ticket? |
7bc74fb
to
603b532
Compare
This looks like a small style/bug fix, good to proceed. |
Description
This pull request contains styling fixes for the
Share this video
functionality for LMS and CMS. Hardcoded styles were also removed and a link to platform brand styles/colors was added.Related Pull Requests
PR to the open-release/quince.master branch: #34810
PR to the open-release/redwood.master branch: #34893
Screenshots before:
Screenshots after:
Steps to Reproduce:
/admin/waffle/flag/