From 6ab4fbae0bdb1b3f289dc104a647d3d57255ee41 Mon Sep 17 00:00:00 2001 From: "Kyle D. McCormick" Date: Wed, 17 Apr 2024 09:25:50 -0400 Subject: [PATCH] feat!: remove SkillTaggingMixin from common XBLOCK_MIXINS This is not a core feature, and it is not installed into core requirements, evidenced by the fact that it must be try-except imported into common.py. Instead, setting updates like this should be made in each operator's private settings file. BREAKING CHANGE: Operators who install the xblock-skilltagging package will need to add SkillTaggingMixin to XBLOCK_MIXINS_EXTRA in a private settings file, as it will no longer be done automatically in private.py. --- lms/envs/common.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lms/envs/common.py b/lms/envs/common.py index 30ba71f62aad..45b9f476cc9b 100644 --- a/lms/envs/common.py +++ b/lms/envs/common.py @@ -67,10 +67,6 @@ from openedx.core.lib.derived import derived, derived_collection_entry from openedx.core.release import doc_version from lms.djangoapps.lms_xblock.mixin import LmsBlockMixin -try: - from skill_tagging.skill_tagging_mixin import SkillTaggingMixin -except ImportError: - SkillTaggingMixin = None ################################### FEATURES ################################### # .. setting_name: PLATFORM_NAME @@ -1654,8 +1650,6 @@ def _make_mako_template_dirs(settings): XModuleMixin, EditInfoMixin, ) -if SkillTaggingMixin: - XBLOCK_MIXINS += (SkillTaggingMixin,) # .. setting_name: XBLOCK_EXTRA_MIXINS # .. setting_default: ()