Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tutor-mfe compatiblilty for atlas pull | FC-0012 #280

Merged
merged 1 commit into from
Feb 2, 2024
Merged

feat: tutor-mfe compatiblilty for atlas pull | FC-0012 #280

merged 1 commit into from
Feb 2, 2024

Conversation

OmarIthawi
Copy link
Member

Similar to openedx/frontend-app-communications#187.

Changes

  • install atlas
  • remove --filter to pull all languages by default
  • use ATLAS_OPTIONS to allow custom --filter
  • include frontend-platform in atlas pull

Refs

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@OmarIthawi
feat: tutor-mfe compatiblilty for atlas pull
6e73cf7 
 - install atlas
 - remove `--filter` to pull all languages by default
 - use ATLAS_OPTIONS to allow custom `--filter`
 - include frontend-platform in `atlas pull`
@OmarIthawi OmarIthawi requested a review from arbrandes February 1, 2024 17:03
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 1, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (69e090e) 96.03% compared to head (6e73cf7) 96.04%.
Report is 1 commits behind head on master.

Files Patch % Lines
...shboardHeader/CollapsedHeader/CollapseMenuBody.jsx 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   96.03%   96.04%           
=======================================
  Files         194      194           
  Lines        1843     1844    +1     
  Branches      326      322    -4     
=======================================
+ Hits         1770     1771    +1     
  Misses         68       68           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OmarIthawi OmarIthawi mentioned this pull request Feb 1, 2024
Merged
14 tasks
brian-smith-tcril
brian-smith-tcril approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov failure is in an unchanged file. This LGTM! :shipit:

@brian-smith-tcril
Copy link
Contributor

@hurtstotouchfire you're listed as "please inform" for this repo on the spreadsheet, I plan on merging this shortly.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Feb 2, 2024
@brian-smith-tcril brian-smith-tcril merged commit 4730cf8 into openedx:master Feb 2, 2024
5 of 6 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

@arbrandes arbrandes Awaiting requested review from arbrandes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OmarIthawi @openedx-webhooks @brian-smith-tcril @itsjeyd