Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test mock cleanup for useMemo #70

Closed
wants to merge 1 commit into from
Closed

Conversation

nsprenkle
Copy link
Contributor

Split out test cleanup from #68 for better modularity.

Copy link
Contributor

@muselesscreator muselesscreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsprenkle
Copy link
Contributor Author

Holding until NOV 21 post release cycle

@justinhynes
Copy link
Contributor

Hi @nsprenkle!

I see that this was approved but never merged. I'm trying to clean up some older PRs in this repo. Is this PR still needed? If so, would you be able to fix up the conflicts so we can see to getting this merged?

Thanks in advance!

@justinhynes justinhynes added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 8, 2024
@justinhynes
Copy link
Contributor

I haven't heard back and this PR is over a year old. Please resubmit a new PR if you'd like to get this change merged!

@justinhynes justinhynes closed this Feb 2, 2024
@justinhynes justinhynes deleted the bw/test-cleanup branch February 26, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants