Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding integrations to the Customer view page #397

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Aug 12, 2024

Description

As part of the enterprise setup support tool update, we created a customer card with relevant customer info.

UI

Screenshot 2024-08-12 at 1 56 26 PM Screenshot 2024-08-12 at 1 56 37 PM Screenshot 2024-08-12 at 1 56 52 PM

Test Plan on Stage

checkout branch kiram15/ENT-9164 and run npm install
testing link: https://localhost.stage.edx.org:18450/enterprise-configuration/customers/

at the root directory, add file webpack.dev.config.js with the following content:
const { createConfig } = require('@openedx/frontend-build');

module.exports = createConfig('webpack-dev', {
devServer: {
allowedHosts: 'all',
https: true,
},
});
replace the content in .env.development with this info:
NODE_ENV='development'
PORT=18450
FEATURE_CUSTOMER_SUPPORT_VIEW='true'
ADMIN_PORTAL_BASE_URL='https://portal.stage.edx.org'
ACCESS_TOKEN_COOKIE_NAME='stage-edx-jwt-cookie-header-payload'
BASE_URL='https://localhost.stage.edx.org:18450'
FEATURE_CONFIGURATION_MANAGEMENT='true'
FEATURE_CONFIGURATION_ENTERPRISE_PROVISION='true'
FEATURE_CONFIGURATION_EDIT_ENTERPRISE_PROVISION='true'
CREDENTIALS_BASE_URL='https://credentials.stage.edx.org'
CSRF_TOKEN_API_PATH='/csrf/api/v1/token'
ECOMMERCE_BASE_URL='https://ecommerce.stage.edx.org'
ENTERPRISE_ACCESS_BASE_URL='https://enterprise-access.stage.edx.org'
LANGUAGE_PREFERENCE_COOKIE_NAME='openedx-language-preference'
LMS_BASE_URL='https://courses.stage.edx.org'
LICENSE_MANAGER_URL='https://license-manager.stage.edx.org'
SUPPORT_CONFLUENCE='https://support-tools.edx.org'
SUPPORT_CUSTOMER_REQUEST='https://support-tools.edx.org'
DISCOVERY_API_BASE_URL='https://discovery.stage.edx.org'
LOGIN_URL='https://courses.stage.edx.org/login'
LOGOUT_URL='https://courses.stage.edx.org/logout'
LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg/
FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
MARKETING_SITE_BASE_URL='https://stage.edx.org'
ORDER_HISTORY_URL='https://orders.stage.edx.org/orders'
REFRESH_ACCESS_TOKEN_ENDPOINT='https://courses.stage.edx.org/login_refresh'
SEGMENT_KEY=null
SITE_NAME='edX'
SUBSIDY_BASE_URL='https://enterprise-subsidy.stage.edx.org'
USER_INFO_COOKIE_NAME='edx-user-info'
PUBLISHER_BASE_URL='https://publisher.stage.edx.org/'
APP_ID='support-tools'
MFE_CONFIG_API_URL='https://courses.stage.edx.org/api/mfe_config/v1'

verify that you can see the integration cards match figma: https://www.figma.com/design/TP5hGfoYmohr21MwgUgCZN/Enterprise-Setup?node-id=914-16353&t=3Fs3hMg0TNnSl7Lv-0
Verify with multiple customers that all 3 cards (API, SSO, and LMS) are all working and showing up.

Jira

https://2u-internal.atlassian.net/browse/ENT-9164

Screen.Recording.2024-08-12.at.12.54.49.PM.mov

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.73%. Comparing base (81ac21f) to head (97c718d).
Report is 8 commits behind head on master.

Files Patch % Lines
src/data/services/EnterpriseApiService.js 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   84.71%   84.73%   +0.01%     
==========================================
  Files         174      177       +3     
  Lines        3645     3674      +29     
  Branches      881      890       +9     
==========================================
+ Hits         3088     3113      +25     
- Misses        543      547       +4     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,3 @@
const DJANGO_ADMIN_BASE_URL = 'https://internal.courses.edx.org';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this value can be configured in .env?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we're pulling from import { getConfig } from '@edx/frontend-platform' so I was talking to Katrina about maybe putting in a ticket to add it in there?

@kiram15 kiram15 merged commit 9ddfb37 into master Aug 15, 2024
7 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9164 branch August 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants