Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding customer detail modal #403

Merged
merged 2 commits into from
Aug 21, 2024
Merged

feat: adding customer detail modal #403

merged 2 commits into from
Aug 21, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Aug 20, 2024

Adding the modal for the "View details" button on the customer card.

Jira ticket

Screen.Recording.2024-08-20.at.1.33.07.PM.mov

Testing link: https://localhost.stage.edx.org:18450/enterprise-configuration/customers/

  • Select customer
  • Click 'View details' in customer card
  • Verify details against Figma

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (9ddfb37) to head (83f2c7a).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   84.73%   84.78%   +0.05%     
==========================================
  Files         177      178       +1     
  Lines        3674     3688      +14     
  Branches      886      895       +9     
==========================================
+ Hits         3113     3127      +14     
  Misses        547      547              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great so far! I just have a few nits/suggestions

@kiram15 kiram15 merged commit 6b3bb62 into master Aug 21, 2024
7 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9168 branch August 21, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants