-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add users table #406
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 84.96% 84.47% -0.49%
==========================================
Files 182 185 +3
Lines 3752 3814 +62
Branches 909 919 +10
==========================================
+ Hits 3188 3222 +34
- Misses 550 570 +20
- Partials 14 22 +8 ☔ View full report in Codecov by Sentry. |
58e1acd
to
7799698
Compare
7799698
to
d10c97d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple things!
src/Configuration/Customers/CustomerDetailView/CustomerPlanContainer.jsx
Outdated
Show resolved
Hide resolved
src/Configuration/Customers/CustomerDetailView/EnterpriseCustomerUsersTable.jsx
Show resolved
Hide resolved
src/Configuration/Customers/CustomerDetailView/CustomerIntegrations.jsx
Outdated
Show resolved
Hide resolved
src/Configuration/Customers/CustomerDetailView/EnterpriseCustomerUsersTable.jsx
Show resolved
Hide resolved
37c55d1
to
d0f4897
Compare
d0f4897
to
5456ed3
Compare
Description
As part of the enterprise setup support tool update, this PR adds a table containing all admins and learners:
Screen.Recording.2024-09-02.at.7.20.04.PM.mov
Test Plan on Stage
knguyen2/ent-9166
and runnpm install
webpack.dev.config.js
with the following content:.env.development
with this info:use a testing enterprise such as https://localhost.stage.edx.org:18450/enterprise-configuration/customers/66b5922b-a22b-4a7b-b587-d4af0378bd6f/view
verify that you can search by a user's username or email.
verify that admins are ordered first and alphabetized followed by learners and alphabetized.

https://2u-internal.atlassian.net/browse/ENT-9166